Use CSS+JS to collapse the display of the patron address in the sidebar on circ and patron related pages. This change is being pulled from Bug 5436 since it's unrelated to patron attributes.
Created attachment 4889 [details] [review] Proposed fix This patch takes the feature implemented in the original patch for Bug 5436 and reimplements it in a slightly more abstracted way. The JavaScript can now be applied to any pair of elements like this: a block with class "collapsed" followed by a link with class "togglecollapse." In the circ-menu include, both the address info block and the link to show/hide it have unique ids ("contact" and "showcontact" respectively) so that IntranetUserCSS can be used to force the address information to show: #contact { display : block; } #showcontact { display : none; }
Incidentally, I thought this was an interesting UI problem to solve, but I'm not convinced that it is necessary. I would be interested in hearing from Biblibre about the motivation for developing it. Was it because adding the display of extended patron attributes was pushing the navigation links down too far? If so we'll have to revisit this in reference to patron attributes. This patch groups "contact information" under one heading. We would need to add an additional "group" for extended attributes (something which this patch facilitates).
That is so cool :) signed off.
Created attachment 5562 [details] [review] Revised fix Revision adds compatibility for display of extended patron attributes and makes changes consistent across includes, including circ-menu.tt.
Created attachment 5563 [details] Screenshot of collapsed patron info in the sidebar This would be the default view: both the contact information block and the library information block are collapsed.
Created attachment 5564 [details] Screenshot of expanded patron info in the sidebar The expanded view shows what information is in each block. Note the "Patron's pets" line is an extended patron attribute.
Tested in Chrome and FF on Mac and I can't get the information to expand. I click the links and nothing happens. Nicole
Created attachment 5631 [details] [review] [SIGNED-OFF] Fix for Bug 6674 - Collapse display of patron address by default This patch takes the feature implemented in the original patch for Bug 5436 and reimplements it in a slightly more abstracted way. The JavaScript can now be applied to any pair of elements like this: a block with class "collapsed" followed by a link with class "togglecollapse." In the circ-menu include, both the address info block and the link to show/hide it have unique ids ("contact" and "showcontact" respectively) so that IntranetUserCSS can be used to force them to show: #contact { display : block; } #showcontact { display : none; } Revision adds compatibility for display of extended patron attributes and makes changes consistent across includes, including circ-menu.tt. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Created attachment 5638 [details] [review] [SIGNED-OFF] Bug 6937 - change "Fines" to "Fees & Charges" on circ page Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment on attachment 5638 [details] [review] [SIGNED-OFF] Bug 6937 - change "Fines" to "Fees & Charges" on circ page sorry i attached this to the wrong report
QA comment: Is it intended to have the headers *below* the information itself. That's quite strange: in MARC editor, for example, when you expand a field, subfields appear after the field. Marking failed QA unless you convince me that should be that way ! (In reply to comment #2) > Incidentally, I thought this was an interesting UI problem to solve, but I'm > not convinced that it is necessary. I would be interested in hearing from > Biblibre about the motivation for developing it. Was it because adding the > display of extended patron attributes was pushing the navigation links down too > far? We were not the original author of the patch, or am I missing something ?
(In reply to comment #11) > We were not the original author of the patch, or am I missing something ? The original changes were found in the patch for Bug 5436.