When viewing the holds queue clicking the arrows to move people around the queue causes an error message saying that the patron already has the item on hold. "Cannot Place Hold Olga Rivera already has a hold on this item" This could be a T:T issue (actually I hope it is).
I rolled back reserve/request.pl to the state it was in before Bug 6526 and found that the arrows were working again. I'm guessing a change in that patch (now pushed) is the cause.
I agree with owen's assessment.
Rats, I guess that'll make it my problem then.
I note that the change does apply, it's just also putting up the error message. (still going to fix it proper though.)
Created attachment 5328 [details] [review] Bug 6687 - allow people to be moved in the holds queue This fixes a regression introduced by Bug 6526 that told you someone already had a reserve if you attempted to move their ordering in the hold queue. (note: it also cleans a host of trailing whitespace errors that were in that file)
Created attachment 5340 [details] [review] [SIGNED-OFF] Bug 6687 - allow people to be moved in the holds queue This fixes a regression introduced by Bug 6526 that told you someone already had a reserve if you attempted to move their ordering in the hold queue. (note: it also cleans a host of trailing whitespace errors that were in that file) Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Primarily white space changes, which are okay. The core content of the file adds a simple additional check to the conditional, which seems okay. Marking as Passed QA
Pushed, please test
Works great, thanks!