The basket number on the receive items table shows the basket number given by Koha, not the basket number the librarian gave it. The librarian doesn't necessarily know the number Koha assigned and so it should show the number that they chose. The same with the filter on the left - it filters on the basket number assigned by Koha, that's not a number the librarian necessarily knows.
Created attachment 5033 [details] basket number
The filter works on the basket name, I suggest we just relabel it to make it more clear. Both the basket name and it's number are shown in the table.
Created attachment 87689 [details] [review] Bug 6730: Rename 'basket' filter to 'basket name' on receive page This way it's clear that you can search for the name here, but not for the number. It also matches the labelling of the other filter: Basket group name below. To test: - Receive shipment - Enter invoice number and go to receive page - Look at the filters on the left - Confirm the changed label and that basket name is searched
Created attachment 88035 [details] [review] Bug 6730: Rename 'basket' filter to 'basket name' on receive page This way it's clear that you can search for the name here, but not for the number. It also matches the labelling of the other filter: Basket group name below. To test: - Receive shipment - Enter invoice number and go to receive page - Look at the filters on the left - Confirm the changed label and that basket name is searched Signed-off-by: Michal Denar <black23@gmail.com>
Created attachment 88157 [details] [review] Bug 6730: Rename 'basket' filter to 'basket name' on receive page This way it's clear that you can search for the name here, but not for the number. It also matches the labelling of the other filter: Basket group name below. To test: - Receive shipment - Enter invoice number and go to receive page - Look at the filters on the left - Confirm the changed label and that basket name is searched Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Woop, woop.. another four digit bug bites the dust.. Passing QA
Awesome work all! Pushed to master for 19.05
Minor string change, not backporting to 18.11.x series.