It would be nice if serial history table in the OPAC included the location information for those who don't create item records for each issue.
We show the library, but not the location, so this is still valid.
Created attachment 128637 [details] [review] Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Full history" tab Test plan: 1)Intranet: Make sure to have at least one Serial/Subscription created with the field 'location' filled in 2)Opac: Find your Serial/Subscription 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Full history' to see the detailed array 5)Apply patch and refresh your browser 6)The location is now above the array
Created attachment 128679 [details] [review] Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Normal view" and "Full history" tabs Test plan: 1)Intranet: Make sure to have at least two different Serials/Subscriptions on the same record with the field 'location' filled in 2)Opac: Find your Serials/Subscriptions 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Normal view' and 'Full history' to notice that 'location' is missing 5)Apply patch, refresh your browser & repeat 4) 6)The location is now visible
Created attachment 129118 [details] [review] Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Normal view" and "Full history" tabs Test plan: 1)Intranet: Make sure to have at least two different Serials/Subscriptions on the same record with the field 'location' filled in 2)Opac: Find your Serials/Subscriptions 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Normal view' and 'Full history' to notice that 'location' is missing 5)Apply patch, refresh your browser & repeat 4) 6)The location is now visible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment on attachment 129118 [details] [review] Bug 6734: Show location in serials history table Review of attachment 129118 [details] [review]: ----------------------------------------------------------------- ::: koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-serial-issues.tt @@ +132,5 @@ > [% END %] > > <h3>[% subscription_LOO.branchname | html %]</h3> > + [% IF ( subscription_LOO.location ) %] > + <p>Location : <em>[% AuthorisedValues.GetByCode( 'LOC', subscription_LOO.location, 1 ) | html | html_line_break %]</em></p> I believe the html_line_break is not needed here as every subscription can only have one location assigned and there should not be any line breaks to convert.
Created attachment 129230 [details] [review] Bug 6734: Show location in serials history table Opac: On a record(Serials) details the location wasn't displayed on the "Normal view" and "Full history" tabs Test plan: 1)Intranet: Make sure to have at least two different Serials/Subscriptions on the same record with the field 'location' filled in 2)Opac: Find your Serials/Subscriptions 3)Click 'More details' and notice the 3 tabs : Normal view, Brief history, Full history 4)Go to 'Normal view' and 'Full history' to notice that 'location' is missing 5)Apply patch, refresh your browser & repeat 4) 6)The location is now visible Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Created attachment 129231 [details] [review] Bug 6734: (QA follow-up) Fix punctuation and TT filters * Changes Location : to Location: * Removes html_line_break filter, as location is not multi-line Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Oh, since Bug 26323 we avoid calling directly 'LOC', prefer AuthorisedValues.GetDescriptionByKohaField() Look at opac-course-details.tt : https://git.koha-community.org/Koha-community/Koha/commit/1e502efa0aef9ca865ff0af6c6ecefee73cc4ee1#diff-20
Also use <span class="shelvingloc"> like in opac-detail.tt
(In reply to Fridolin Somers from comment #9) > Also use <span class="shelvingloc"> like in opac-detail.tt I have tried that out and it didn't work well since there is a CSS style attached to it. But: the subscription location already shows in the subscription tab with the class "subscription_location", so I've used that in the other spots which makes things consistent :)
Created attachment 129740 [details] [review] Bug 6734: (QA follow-up) Fix punctuation, TT filters, and CSS class * Changes Location : to Location: * Removes html_line_break filter, as location is not multi-line * Add subscription_location CSS class * Use AuthorisedValues.GetDescriptionByKohaField() Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> https://bugs.koha-community.org/show_bug.cgi?id=6743
(In reply to Katrin Fischer from comment #10) > (In reply to Fridolin Somers from comment #9) > > Also use <span class="shelvingloc"> like in opac-detail.tt > > I have tried that out and it didn't work well since there is a CSS style > attached to it. But: the subscription location already shows in the > subscription tab with the class "subscription_location", so I've used that > in the other spots which makes things consistent :) Great :)
Pushed to master for 22.05, thanks to everybody involved [U+1F984]