Bug 6751 - Link in readingrec.pl to export a barcode file
Summary: Link in readingrec.pl to export a barcode file
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Patrons (show other bugs)
Version: 3.8
Hardware: All All
: P2 enhancement (vote)
Assignee: Jonathan Druart
QA Contact: Bugs List
URL:
Keywords:
Depends on: 8154
Blocks:
  Show dependency treegraph
 
Reported: 2011-08-19 09:46 UTC by Jonathan Druart
Modified: 2013-12-05 20:01 UTC (History)
8 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.77 KB, patch)
2011-08-19 09:55 UTC, Jonathan Druart
Details | Diff | Splinter Review
rebased patch (2.71 KB, patch)
2012-01-02 12:30 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 6751: Adds a link "Export checkin barcodes" in readingrec (2.76 KB, patch)
2012-01-13 07:54 UTC, Chris Cormack
Details | Diff | Splinter Review
Bug 6751 Remplace encoding mode for perlcritic (877 bytes, patch)
2012-01-18 09:16 UTC, Jonathan Druart
Details | Diff | Splinter Review
Rebased and Squashed version (2.84 KB, patch)
2012-02-10 10:20 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 6751 Followup Move export action into the More toolbar (3.64 KB, patch)
2012-02-15 11:47 UTC, Jonathan Druart
Details | Diff | Splinter Review
Bug 6751: Adds a link "Export checkin barcodes" in readingrec (2.93 KB, patch)
2012-03-03 16:38 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 6751: Followup: Move export action into the "More" toolbar (3.87 KB, patch)
2012-03-03 16:38 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 6751 Followup minors fixes (2.01 KB, patch)
2012-03-07 16:39 UTC, Jonathan Druart
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6751: Adds a link "Export checkin barcodes" in readingrec (5.30 KB, patch)
2012-03-09 15:57 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Druart 2011-08-19 09:46:12 UTC
In the "Circulation History" tab, it should be possible to export a file containing a list of checkin barcode for the current day.
Comment 1 Jonathan Druart 2011-08-19 09:55:03 UTC Comment hidden (obsolete)
Comment 2 claire.hernandez@biblibre.com 2011-12-02 13:45:06 UTC
$ git-bz apply 6751
Bug 6751 - Link in readingrec.pl to export a barcode file

Proposed patch
Apply? [yn] y

Applying: Bug 6751: Adds a link "Export checkin barcodes" in readingrec
error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt:31
error: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt: patch does not apply
error: patch failed: members/readingrec.pl:29
error: members/readingrec.pl: patch does not apply
Patch failed at 0001 Bug 6751: Adds a link "Export checkin barcodes" in readingrec
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Patch left in /tmp/Proposed-patch-dq1fbK.patch
Comment 3 claire.hernandez@biblibre.com 2011-12-02 14:51:34 UTC
Forget it, applies well with a 3-way merge in git bz

(In reply to comment #2)
Comment 4 Katrin Fischer 2011-12-21 07:17:12 UTC
Does not apply to current master (using git am -i3u)

Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 6751: Adds a link "Export checkin barcodes" in readingrec
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt
Auto-merging members/readingrec.pl
Failed to merge in the changes.
Patch failed at 0001 Bug 6751: Adds a link "Export checkin barcodes" in readingrec
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Comment 5 Jonathan Druart 2012-01-02 12:30:16 UTC Comment hidden (obsolete)
Comment 6 Chris Cormack 2012-01-13 07:54:19 UTC Comment hidden (obsolete)
Comment 7 Paul Poulain 2012-01-17 16:36:27 UTC
QA comment: 
perlcritic failure.
* perlcritic is OK before the patch
* after the patch:
perlcritic members/readingrec.pl 
I/O layer ":utf8" used at line 95, column 5.  Use ":encoding(UTF-8)" to get strict validation.  (Severity: 5)
Comment 8 Jonathan Druart 2012-01-18 09:16:52 UTC Comment hidden (obsolete)
Comment 9 Paul Poulain 2012-02-01 17:28:59 UTC
The patch does not apply anymore, because of a conflict with Datatables patch that has been pushed (bug 6836)
Comment 10 Jonathan Druart 2012-02-10 10:20:14 UTC Comment hidden (obsolete)
Comment 11 Paul Poulain 2012-02-15 08:51:29 UTC
QA comment:
* the code itself is OK
* percritic still OK after patch applied
One thing that make me mark "failed QA" though:

1- the description is "Export checkin barcodes". I can't see anywhere that it's related to "today" checked-in barcode. We will get new bug entries for this "bug". Please rename to "Export today checkin barcodes" & add some information to online help (koha-tmpl/intranet-tmpl/prog/en/help/members/readingrec.pl)

2- Last comment: the link is alone on readingrec.pl. I think it would be better to add it as an option in the "More" toolbar.

Marking failed QA for #1, but as you'll submit a new patch, please also fix #2, it will be more graphically consistent
Comment 12 Jonathan Druart 2012-02-15 11:47:56 UTC Comment hidden (obsolete)
Comment 13 Jared Camins-Esakov 2012-03-03 16:38:09 UTC Comment hidden (obsolete)
Comment 14 Jared Camins-Esakov 2012-03-03 16:38:24 UTC Comment hidden (obsolete)
Comment 15 Ian Walls 2012-03-05 18:59:57 UTC
$delimiter is defined as ":", then immediately redefined as "\n".  This seems unintentional... 

Also a small grammatical error in the followup patch:

You can export the today checkin barcodes by...

Easy enough fixes, but marking as Failed QA until they're resolved.
Comment 16 Jonathan Druart 2012-03-07 16:39:48 UTC Comment hidden (obsolete)
Comment 17 Owen Leonard 2012-03-09 15:57:33 UTC
Created attachment 8124 [details] [review]
[SIGNED-OFF] Bug 6751: Adds a link "Export checkin barcodes" in readingrec

to export a file containing a list of checkin barcode for the current day.

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Comment 18 Ian Walls 2012-03-09 20:08:10 UTC
Fixes issues I noticed in QA.  Marking as Passed now.