Bug 6769 - Getting rid of some RIS format export errors and warnings
Summary: Getting rid of some RIS format export errors and warnings
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Marcel de Rooy
QA Contact: Bugs List
URL:
Keywords:
Depends on: 6822
Blocks: 5780
  Show dependency treegraph
 
Reported: 2011-08-24 14:15 UTC by Marcel de Rooy
Modified: 2012-10-25 23:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (16.32 KB, patch)
2011-08-24 14:24 UTC, Marcel de Rooy
Details | Diff | Splinter Review
Revised patch (16.53 KB, patch)
2011-08-24 15:06 UTC, Marcel de Rooy
Details | Diff | Splinter Review
signed-off patch (16.61 KB, patch)
2011-08-30 18:53 UTC, Galen Charlton
Details | Diff | Splinter Review
6769 Getting rid of some RIS errors/warnings (16.68 KB, patch)
2011-10-06 14:21 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2011-08-24 14:15:28 UTC
Removing unnecessary warnings like below. Some were based on errors in the script. Others are removed by adding debug flag and disabling debugging mode by default.

[Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no type found - assume BOOK at /usr/share/koha/prodclone/C4/Ris.pm line 355.
[Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: empty series title field at /usr/share/koha/prodclone/C4/Ris.pm line 521.
[Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no isbn found at /usr/share/koha/prodclone/C4/Ris.pm line 552.
[Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no issn found at /usr/share/koha/prodclone/C4/Ris.pm line 574.
[Wed Aug 24 13:33:01 2011] [error] [client 66.249.72.167] [Wed Aug 24 13:33:01 2011] opac-export.pl: no LOC call number found at /usr/share/koha/prodclone/C4/Ris.pm line 596.
[Wed Aug 24 15:52:36 2011] [error] [client 82.173.53.17] [Wed Aug 24 15:52:36 2011] opac-export.pl: no Dewey number found at /usr/share/koha/prodclone/C4/Ris.pm line 611.
[Wed Aug 24 15:44:51 2011] [error] [client 82.173.53.17] [Wed Aug 24 15:44:51 2011] opac-export.pl: name >>Cantor, Mircea<< in direct order - leave as is at /usr/share/koha/prodclone/C4/Ris.pm line 382.
Comment 1 Marcel de Rooy 2011-08-24 14:24:30 UTC Comment hidden (obsolete)
Comment 2 Marcel de Rooy 2011-08-24 14:26:59 UTC
Test it with:
http://yourserver.com/cgi-bin/koha/opac-export.pl?bib=yourbibnumber&format=ris&op=export 

Replace your server and biblionumber!
Comment 3 Marcel de Rooy 2011-08-24 14:36:53 UTC
Forgot to mention: Adding CRs (carriage returns) before LF (linefeed) for Windows users, downloading this format. Assume that CR does not hurt the Linux downloader.
Comment 4 Owen Leonard 2011-08-24 14:52:28 UTC
I'm curious whether you're getting valid RIS exports? The patch seems to work--I'm not getting errors in the log after applying it. But with our without the patch my RIS exports are almost completely empty:

TY  - BOOK
ER  -
Comment 5 Marcel de Rooy 2011-08-24 14:54:23 UTC
I have something like:
TY  - BOOK
AU  - Manca, Angelo
TI  - Vermeer: pingo ergo sum 
T2  - Collezione MercatorSN  - 8872552575
PY  - 2005///
CY  - Firenze
PB  - Firenze Atheneum
KW  - schilderijen
KW  - Vermeer, Johannes,
KW  - geometrie en kunst
ER  -
Comment 6 Marcel de Rooy 2011-08-24 14:59:57 UTC
Will send a revision for the missing newline after T2 (as in the above example).
Comment 7 Marcel de Rooy 2011-08-24 15:06:06 UTC Comment hidden (obsolete)
Comment 8 Galen Charlton 2011-08-30 18:53:59 UTC Comment hidden (obsolete)
Comment 9 Galen Charlton 2011-08-30 19:20:20 UTC
Also received a user report to the effect that RIS output with this patch installed is being successfully parsed by Reference Manager.
Comment 10 Paul Poulain 2011-10-06 14:21:08 UTC
Created attachment 5740 [details] [review]
6769 Getting rid of some RIS errors/warnings

Removing unnecessary warnings. Some were based on errors in the script. Others are removed by adding debug flag and disabling debugging mode by default.
Adding carriage returns for Windows users, assuming that it does not hurt the Linux users. (Perhaps a future option?)
Test it with: http://yourserver.com/cgi-bin/koha/opac-export.pl?bib=yourbibnumber&format=ris&op=export [replace server and biblionumber]

Revision of Aug 24: Fixed two missing newlines too.

Signed-off-by: Steven Callender <stevecallender@esilibrary.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
  (removed comment "240811 marcelr during QA"
Comment 11 Paul Poulain 2011-10-06 14:22:59 UTC
QA comment
* description & test plan clear
* cosmetic (remove warnings) patch
* I just removed a "240811 marcelr", that is something we should not have in code, as it's in git repo

marking passed QA
Comment 12 Chris Cormack 2011-10-07 01:03:03 UTC
Pushed please test