Bug 6783 - Circulation restrictions dont work when other withdrawn reasons are used
Summary: Circulation restrictions dont work when other withdrawn reasons are used
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement
Assignee: Meenakshi
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-25 04:49 UTC by Savitra Sirohi
Modified: 2013-12-05 19:53 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug id:6783 - Circulation restrictions dont work when other withdrawn reasons are used (1.02 KB, patch)
2011-09-08 05:57 UTC, Amit Gupta 		Details | Diff | Splinter Review
[SIGNED-OFF] Bug id:6783 - Circulation restrictions dont work when other withdrawn reasons are used (1.09 KB, patch)
2011-09-10 22:17 UTC, Nicole C. Engard 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Savitra Sirohi 2011-08-25 04:49:56 UTC 
Circulation restrictions work only when withdrawn reason (value 1) is selected. If ones sets up other withdrawn reasons using authorized values, and selects one of them (e.g. value 2), circulation restrictions don't work. This changes fixes this problem.
Comment 1 Amit Gupta 2011-09-08 05:57:59 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2011-09-08 13:37:03 UTC 
From a documentation standpoint - can you explain this further?  What circulation restrictions are you talking about? How are you setting them up?
Comment 3 Savitra Sirohi 2011-09-09 04:54:52 UTC 
Nicole, for withdrawn items regular circ transactions -- checkout, checkin and renewals are not allowed. This change extends those same restrictions to other withdrawn reasons.
Comment 4 Nicole C. Engard 2011-09-10 22:10:49 UTC 
Oh! Okay, that I understand. I'll try and test this now.
Comment 5 Nicole C. Engard 2011-09-10 22:17:32 UTC 
Created attachment 5394 [details] [review]
[SIGNED-OFF] Bug id:6783 - Circulation restrictions dont work when other withdrawn reasons are used

Circulation restrictions work only when withdrawn reason (value 1) is selected.
If ones sets up other withdrawn reasons using authorized values, and selects
one of them (e.g. value 2), circulation restrictions don't work. This changes
fixes this problem.

Signed-off-by: Amit Gupta <amit.gupta@osslabs.biz>
Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 6 Ian Walls 2011-09-11 00:30:14 UTC 
Easy to read patch, makes "Withdrawn" behave more like other non-circ statuses.  Marking as Passed QA.
Comment 7 Chris Cormack 2011-09-11 09:42:09 UTC 
Pushed, please test
Comment 8 Jared Camins-Esakov 2012-05-23 12:52:56 UTC 
Seems to work. Closing.