Bug 6806 - Encoding problem with biblio titles in subscription-add.pl
Summary: Encoding problem with biblio titles in subscription-add.pl
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: rel_3_2
Hardware: All All
: P5 - low minor (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-08-29 17:32 UTC by Maxime Pelletier
Modified: 2012-10-25 23:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Corrects encoding problems in biblio title of subscription-add.pl (2.09 KB, application/octet-stream)
2011-08-29 17:32 UTC, Maxime Pelletier
Details
Patche reworked to use TT (1.95 KB, patch)
2011-08-30 14:07 UTC, Colin Campbell
Details | Diff | Splinter Review
Signed-off patch (2.01 KB, patch)
2011-09-20 18:34 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 6806 Fix encoding of title in subscription-add (2.01 KB, patch)
2011-10-14 10:10 UTC, Paul Poulain
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Pelletier 2011-08-29 17:32:44 UTC Comment hidden (obsolete)
Comment 1 Colin Campbell 2011-08-30 14:07:12 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2011-08-30 14:30:19 UTC
Are you sure it doesn't work on HEAD. For me, HEAD branch doesn't show this bug.
Comment 3 Colin Campbell 2011-08-30 14:33:55 UTC
Yes I managed to reproduce the bug on head. Applied the patch and it fixed the encoding
Comment 4 Maxime Pelletier 2011-09-20 18:27:31 UTC
My patch also fixes that the "choose" link doesn't work if there's a "'" in the title.
Anyone could sign off on this?
Comment 5 Owen Leonard 2011-09-20 18:34:33 UTC Comment hidden (obsolete)
Comment 6 Owen Leonard 2011-09-20 18:35:31 UTC
(In reply to comment #5)
> Signed-off patch

...Should have specified: For master.
Comment 7 Paul Poulain 2011-10-14 10:10:14 UTC
Created attachment 5887 [details] [review]
Bug 6806 Fix encoding of title in subscription-add

Port of Maxime Pelletier <maxime.pelletier@libeo.com>'s patch for
3.2 to TT
Stops the mangling of titles containing accented characters

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Paul Poulain <paul.poulain@biblibre.com>
Comment 8 Paul Poulain 2011-10-14 10:11:42 UTC
QA comment :
  * good description
  * small patch

passed QA

RM = no change in strings despite it's a templates change, can be pushed
Comment 9 Chris Cormack 2011-10-15 00:58:54 UTC
Pushed, please test