The page of basket groups does not quite match the style of the rest of Koha. Also, the buttons with text on them (reopen and print) are very small and kinda hard to read. It would be nice to see this page get a bit of love in the design department.
Created attachment 6045 [details] Screenshot This is still an issue in Koha 3.6 Besides the colors the used fonts are very small, making it hard to read and work with the page.
Created attachment 6074 [details] [review] Proposed fix I've made changes to the basket grouping interface to bring it in line with other interfaces in Koha. I think it's better to keep things following a consistent pattern. On the page which lists basket groups: - Basket groups listed in a table instead of as custom-styled lists - Buttons use standard style - Tabs are generated by jQuery On the page for managing baskets in a group: - Markup has been revised to be more consistent with established patterns. - Corrections have been made for validity On the basket view page: - Display of data has been streamlined a little bit - An option has been added to the "Basket group" dropdown for adding a new group - Markup has been corrected for validity and consistency
Created attachment 6215 [details] [review] Fix for Bug 6818 - acquisitions basket groups could use some design work I've made changes to the basket grouping interface to bring it in line with other interfaces in Koha. I think it's better to keep things following a consistent pattern. On the page which lists basket groups: - Basket groups listed in a table instead of as custom-styled lists - Buttons use standard style - Tabs are generated by jQuery On the page for managing baskets in a group: - Markup has been revised to be more consistent with established patterns. - Corrections have been made for validity On the basket view page: - Display of data has been streamlined a little bit - An option has been added to the "Basket group" dropdown for adding a new group - Markup has been corrected for validity and consistency Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Basket group page The blue is gone and the new buttons are much better readable than before. 2) Basket grouping page Works. 3) Basket view page I like the new option to create a new group from here. Nice improvement to the workflow! I removed a spare 'td' from line 264.
Created attachment 6216 [details] [review] Fix for Bug 6818 - acquisitions basket groups could use some design work I've made changes to the basket grouping interface to bring it in line with other interfaces in Koha. I think it's better to keep things following a consistent pattern. On the page which lists basket groups: - Basket groups listed in a table instead of as custom-styled lists - Buttons use standard style - Tabs are generated by jQuery On the page for managing baskets in a group: - Markup has been revised to be more consistent with established patterns. - Corrections have been made for validity On the basket view page: - Display of data has been streamlined a little bit - An option has been added to the "Basket group" dropdown for adding a new group - Markup has been corrected for validity and consistency Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> 1) Basket group page The blue is gone and the new buttons are much better readable than before. 2) Basket grouping page Works. 3) Basket view page I like the new option to create a new group from here. Nice improvement to the workflow! I removed a spare 'td' from line 264.
QA comment: * templates still passing tests : prove xt/author/valid-templates.t says xt/author/valid-templates.t .. ok All tests successful. Files=1, Tests=672, 38 wallclock secs ( 0.31 usr 0.01 sys + 36.97 cusr 0.50 csys = 37.79 CPU) Result: PASS * template only markup * there was a tiny merge conflict I solved (an added empty line) passed QA Patch pushed, please test Chris_n = no change in the workflow, but important changes in the design (for more consistency though). I would not object any decision (merging in 3.6 or no), both are debatable
Included in 3.6 prior to 3.6.5.