Will submit a patch that uses jQuery DataTables plugin to add pagination and filtering on subscriptions table (serials-home.pl) It will be a kind of 'how to use datatables' patch.
Created attachment 5295 [details] [review] Patch This patch use dataTables instead of tablesorter for subscriptions table in serials-home.pl This table has now pagination, sorting, and can be filtered in two ways: by a global search field which search on all columns (except those marked with "bSearchable": false), and by a by column search field (which is in the table footer).
Created attachment 5342 [details] buggy This is cool but it has a few bugs in Firefox and Chrome on Mac. First the new subscription button isn't a button anymore. Next the search boxes below the table don't do anything. I type in them and it doesn't filter the results and there isn't a search button so I don't know how to search using those boxes.
Did you pick up the last patch on bug 6836? This patch introduces a minor change that modify a javascript function name. I think this is why you experienced some bugs. I just tried to apply both patches on master, and it works for me (Firefox 6).
I missed the dependency note above.
My fault, I thought I had said it in 1st comment...
With the bug for 6836 applied, this works. I'm finding the whole table to be wider, and with a smaller font size, so we may need to adjust the CSS. I'd also like the ISSN column narrower, since ISSN is 9 char long and doesn't require any more than that. Also, condensing the last three columns to one ("Actions") with each action either on their own line, or separated by space, may help narrow the table. All in all, successful, at least on Mac + FF7. Other systems need testing, as well.
Comment on attachment 5342 [details] buggy Obsoleting screenshot, since this issue goes away when 6836 is applied
Created attachment 6472 [details] [review] Signed-off patch adding DataTable to serial-home.pl page It works as described in serials-home.pl page. And with Owen styling patch, it looks great.
Created attachment 6526 [details] [review] New patch Rebased on what have been done in bug 6836
Applies fine, but after it's applied I get : Software error: Template process failed: file error - datatables-strings.inc: not found at /home/nengard/kohaclone/C4/Templates.pm line 125. For help, please send mail to the webmaster (webmaster@debian), giving this error message and the time and date of the error. on the serials_home
I think you need to retrieve the last version of datatables patches that add this missing file. See bug 6836.
I missed that depends on note - sorry about that. So I can't test this without 6836 Nicole
Created attachment 7370 [details] [review] Bug 6838: Add pagination and filtering on subscriptions table Use dataTables plugin Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Nice work, Julian! This looks *GREAT*!
QA comment There is a small difference between readingrec (that is using Table sorter) and serials filter : the previous/next button have the text AND the button on this patch, there is only the button on readingrec. There is a 1 between pagination button on this patch, nothing on readingrec For consistency reason, please do on this patch as on readingrec. QA comment #2: I think the following code : if ( $previousbiblio eq $line->{biblionumber} ) { # Disabled for sorting and filtering on issn and title # to work on serials-home.pl #$line->{title} = ""; #$line->{issn} = ""; } else { $previousbiblio = $line->{biblionumber}; $odd = -$odd; } $line->{toggle} = 1 if $odd == 1; is useless. i've removed it, without seing any difference. Could you check ? if i'm right, the "my $previousbiblio='' and my $odd=1 " a few lines before are useless too
Created attachment 7445 [details] [review] Bug 6838: Add pagination and filtering on subscriptions table New patch with QA comments taken into account: - Use "four_button" pagination type like in readingrec.pl page - Remove useless $odd and $previousbiblio (both in .pl and .tt)
Created attachment 7492 [details] [review] [SIGNED-OFF] Bug 6838: Add pagination and filtering on subscriptions table Use dataTables plugin Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com> Signed-off-by: Owen Leonard <oleonard@myacpl.org>
QA comment: this time, no comment, passed QA, graphical consistency OK & dead code removed. template change only (except for the dead code remove)
Ok in master, marked as resolved