1) Select of library broken When selecting a library and clicking 'choose' the page reloads but the pull down jumps back to the first branch in the list 2) Can't save changes If you change the checkboxed for the selected library and click 'save' nothing happens. Page does not reload, there is no message displayed and changes are not saved.
Created attachment 5438 [details] [review] Proposed fix - Changing library select form so that chosen library is preselected To test, use the form to switch libraries. The library you switch to should now be pre-selected in the <select> form. - Changing pager <form> to a <p> so that nested form tags don't conflict. It was the addition of the javascript table pager which broke the functionality on this page. To test, make changes to the selections under a collection code's policy. Submitting the form should work, and the selections you make should be reflected when the page reloads.
Created attachment 5471 [details] [review] [SIGNED-OFF] Fix for Bug 6842 - Branch transfer limits broken - Changing library select form so that chosen library is preselected - Changing pager <form> to a <p> so that nested form tags don't conflict. It was the addition of the javascript table pager which broke the functionality on this page. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> - It's possible to select a different library now. The pull down shows the chosen library correctly. - I can make changes and save them without any problems.
Mainly a template change, with one additional param in the Perl. Easy to read, correct HTML nesting, marking as Passed QA
Pushed please test
I tested this on current master and can't save changes to branch transfer limists. Clicking on 'save' gives no reaction.
Created attachment 6923 [details] [review] patch proposed.
Created attachment 6925 [details] [review] followup patch : assigns a problem of deleted information when editing an other branch
Created attachment 6944 [details] [review] Alternate fix which doesn't require Datatables plugin The patch which moved the table pager markup into an include undid the fix which was previously pushed for this problem. Re-implementing the fix in the pager include is a simpler fix which doesn't depend on the Datatables plugin. The markup change in table-pager.inc fixes the problem in branch transfer limits and does not affect functionality on other pages. The changes in this patch to branch_transfer_limits.tt and staff-global.css are for cosmetic reasons only. Note that I don't submit this patch because I disapprove of the use of Datatables but because I think a simpler fix is more expedient in this case.
Created attachment 6960 [details] [review] [SIGNED-OFF] Bug 6842 Alternate fix, Branch transfer limits broken The patch which moved the table pager markup into an include undid the fix which was previously pushed for this problem. Re-implementing the fix in the pager include is a simpler fix which doesn't depend on the Datatables plugin. The markup change in table-pager.inc fixes the problem in branch transfer limits and does not affect functionality on other pages. The changes in this patch to branch_transfer_limits.tt and staff-global.css are for cosmetic reasons only. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Saving changes works now correctly. I tried: - uncheck all for a branch - check all for a branch - making changes for different itemtypes on different tabs
I had no problems deleting branch transfer rules, so I am not sure how to test the second patch attached to this bug. Moving this to signed off for now.
Katrin: about the 2nd patch, here is the test case: * select a branch * unselect some checkboxes to prevent transfer * save * change your branch * unselect some checkboxes and save * go back to the 1st branch => everything is checked again ! This is because the SQL delete everything and not only the branch rules you're saving ! I've tested the patch, please test it too, so I can QA & push both patches I'll obsolet the 1st patch
Comment on attachment 6923 [details] [review] patch proposed. obsoleted by owen patch
Created attachment 7477 [details] [review] [SIGNED-OFF] followup patch : assigns a problem of deleted information when editing an other branch I see now why the follow-up patch is required. If you make a change to a one branch the correct changes are saved. If you make a change to another branch after that the changes to the first branch are lost. The patch fixes that problem.
Initial patch: template only change, replacing <form> with <p>, and updating the necessary CSS. Unfortunately, it does not apply to current master. Rebased patch forthcoming. Followup patch: alters the subroutine DeleteBranchTransferLimits() to take a branchcode param. Subsequently alters ALL usages of this subroutine in Koha (only one) to make use of this new param. Marking Passed QA.
Created attachment 7484 [details] [review] Bug 6842 Alternate fix, Branch transfer limits broken The patch which moved the table pager markup into an include undid the fix which was previously pushed for this problem. Re-implementing the fix in the pager include is a simpler fix which doesn't depend on the Datatables plugin. The markup change in table-pager.inc fixes the problem in branch transfer limits and does not affect functionality on other pages. The changes in this patch to branch_transfer_limits.tt and staff-global.css are for cosmetic reasons only. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Saving changes works now correctly. I tried: - uncheck all for a branch - check all for a branch - making changes for different itemtypes on different tabs
CSS conflict from local cover images development. Rebased now, marking both patches here as Passed QA.
This fix was included in the 3.6.x branch prior to 3.6.4.