Since the addition of Fast Add to circulation (when scanning an unknown barcode, an option is given to Fast Add at that point), some of the default behaviors for the previous existing functionality has changed. If Fast Add is selected from the Circulation mainpage (not within a checkout), or if it is selected as the framework via cataloging, when items are saved, the page redirects to a blank checkout page, rather than to the details or items pages for that biblio. This makes it very difficult for the librarian to confirm their changes have saved, since the newly added biblio will not be available for search until rebuild_zebra.pl next runs. The system should be able to detect the lack of borrowernumber and other passed checkout variables, and change the redirect accordingly.
Created attachment 5381 [details] [review] Proposed Patch Adds a conditional check for whether a borrowernumber has been passed; if so, then continue on to circ/circulation to complete transaction. Otherwise, remain on additem.pl as normal (we're cataloging)
Created attachment 5393 [details] [review] [SIGNED-OFF] Bug 6861: Fast Add returns to circ/circulation.pl in all cases If Fast Add is accessed from either the circulation homepage or cataloguing, it should stay on the additem.pl page after saving the first item. Only when a Fast Add is done in the middle of a circulation transaction should it redirect back to circ/circulation.pl to complete that transaction. This patch adds a conditional check for a borrowernumber input param; the presense of such implies we're in the middle of a checkout. It's absense implies we should remain on additem.pl Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Passing my own patch through QA, since it only adds a single check for a (required) parameter that is used in constructing the redirect URL... since URL won't work without that param, makes sense to check for it, right? Right? Please object if you do not agree with my doing this.
Pushed, please test
Seems to work. Closing.