Bug 6900 - In XSLT, OPAC display of availability needs a line break when both loan and not-for-loan items present
Summary: In XSLT, OPAC display of availability needs a line break when both loan and n...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: OPAC (show other bugs)
Version: 3.4
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: D Ruth Holloway
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-21 15:49 UTC by D Ruth Holloway
Modified: 2012-10-25 23:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
proposed patch (1.29 KB, patch)
2011-09-21 15:53 UTC, D Ruth Holloway
Details | Diff | Splinter Review
Signed-off patch (1.29 KB, patch)
2011-09-21 16:15 UTC, Jared Camins-Esakov
Details | Diff | Splinter Review
Bug 6900 - line break between available and reference items (1.50 KB, patch)
2011-09-22 15:35 UTC, Liz Rea
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description D Ruth Holloway 2011-09-21 15:49:54 UTC
If there are both items available for loan, and items for reference, it will help the display of XSLT results (hitlist) for there to be a line-break between the two lines.  You don't want a non-negotiable line-break, as that would put a break before a reference-only list, which you don't want.  

Patch for this coming shortly.
Comment 1 D Ruth Holloway 2011-09-21 15:53:21 UTC Comment hidden (obsolete)
Comment 2 Jared Camins-Esakov 2011-09-21 16:15:11 UTC
Created attachment 5514 [details] [review]
Signed-off patch
Comment 3 Ian Walls 2011-09-21 17:07:32 UTC
XSLT-only change, well-nested conditional, marking as Passed QA
Comment 4 Chris Cormack 2011-09-21 22:15:32 UTC
Pushed to master, please test
Comment 5 D Ruth Holloway 2011-09-22 12:26:33 UTC
That's got it!
Comment 6 Liz Rea 2011-09-22 15:35:03 UTC Comment hidden (obsolete)
Comment 7 Liz Rea 2011-09-22 15:36:42 UTC
Comment on attachment 5543 [details] [review]
Bug 6900 - line break between available and reference items

I don't even know what I did, but that is not at all what I intended to do.

sighs.