While testing a patch for suggestions I wondered about the different terms used for 'fresh' suggestions. When you create a suggestion it goes into tab 'pending'. But the status for that is 'asked'. The naming should at least be consistent. Does 'asked' make sense? Perhaps we should rename it to something like 'suggested'?
I'd say it should be 'pending' everywhere. Why use diff language in diff places?
I think that too - it should be consistent.
Created attachment 5872 [details] [review] Bug 6904: Changes 'asked' to 'pending' in suggestions for more consistency In some places the suggestions were 'pending' in others the same status was named 'pending'. This patch changes the status to 'pending' in all places on the suggestion page to make it more consistent.
Created attachment 5893 [details] [review] [SIGNED-OFF] Bug 6904: Changes 'asked' to 'pending' in suggestions for more consistency In some places the suggestions were 'pending' in others the same status was named 'pending'. This patch changes the status to 'pending' in all places on the suggestion page to make it more consistent. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Simple template change, but introduces new strings. Marking as Passed QA; integration is up to RM.
This has been pushed: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=1576e3f410b3c4914d1b803953f64e32c20d3e74
Patch has been pushed, but got the link from the wrong tab - correct link: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=087bb15e7003cb1f5e271b5b88c1abb99f33c89c
All instances of 'asked' are changed to 'pending' now on current master/3.6