The log viewer's search form will go back to the default values after submit. There is no way to see what you have searched for after submitting, which is quite annoying.
Created attachment 37294 [details] [review] Bug 6911: Remember search terms in the log viewer tool The modules and actions selected by the user are now selected when a log search is done. Note that this patch also add the multiple attribute to the actions select in order to add the ability to select several actions. The code to do that already existed. Test plan: 1/ Go on the log viewer tool (tools/viewlog.pl) 2/ Launch a search with modules and actions selected. 3/ Confirm that the values you have selected is still selected after the search.
Created attachment 37321 [details] [review] [Signed-off] Bug 6911: Remember search terms in the log viewer tool The modules and actions selected by the user are now selected when a log search is done. Note that this patch also add the multiple attribute to the actions select in order to add the ability to select several actions. The code to do that already existed. Test plan: 1/ Go on the log viewer tool (tools/viewlog.pl) 2/ Launch a search with modules and actions selected. 3/ Confirm that the values you have selected is still selected after the search. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch>
Created attachment 37510 [details] [review] [PASSED QA] Bug 6911: Remember search terms in the log viewer tool The modules and actions selected by the user are now selected when a log search is done. Note that this patch also add the multiple attribute to the actions select in order to add the ability to select several actions. The code to do that already existed. Test plan: 1/ Go on the log viewer tool (tools/viewlog.pl) 2/ Launch a search with modules and actions selected. 3/ Confirm that the values you have selected is still selected after the search. Patch works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Thx Jonathan!
Patch pushed to master. Thanks Jonathan!
This patch removes too many lines and introduced a bug. If you come from the biblio detail page and click on "modification log", you should get the circ menu, not the tools menu.
Created attachment 37961 [details] [review] Bug 6911: (follow-up) Reintroduce few lines to avoid regression If you come from the biblio detail page and click on "modification log", you should get the circ menu, not the tools menu. Test plan: 1/ Go on a biblio detail page 2/ Click on the "modification log" tab 3/ You should get the modification log page with the circ menu.
Quick patch, easy to test. Could I get a quick QA look please?
Created attachment 37968 [details] [review] [PASSED QA] Bug 6911: (follow-up) Reintroduce few lines to avoid regression If you come from the biblio detail page and click on "modification log", you should get the circ menu, not the tools menu. Test plan: 1/ Go on a biblio detail page 2/ Click on the "modification log" tab 3/ You should get the modification log page with the circ menu. Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
QA followup pushed. Thanks Jonathan!
Template changes, held for 3.18.7
*** Bug 11600 has been marked as a duplicate of this bug. ***
Applied on 3.18.x will be in 3.18.7