This is a repeatable bug on a stock Debian squeeze fresh install with default Terminal settings (black text on white background). Simply run perl koha_perl_deps.pl -a -c The script's assertion of 'bold white' affects the Terminal shell prompt, which on default Terminal settings makes it white on white, a.k.a. suboptimal. A correction is proposed in two parts. First, use blue not white for the header and footer, as this should render fine for both default Terminal settings and for those workers who prefer light text on a dark background. Second, at the end of the utility we should return the shell to the condition we found it in regardless of report color settings. This seems to do it: print color 'reset' if $color; I will submit a patch shortly.
Created attachment 5584 [details] [review] proposed 6914 patch
Comment on attachment 5584 [details] [review] proposed 6914 patch The first patch file attached here (2011-09-25 23:31 UTC) is flawed because I was more intent on learning git commands and work flow than the code. The 'reset' should be after the footer print line. Sorry, I will send a corrected patch.
Created attachment 5591 [details] [review] patch attempt 2 with correct ordering of the color reset
Created attachment 6511 [details] [review] Bug 6914 - fixes for the color option of koha_perl_deps.pl Reset the terminal color mode after reporting (to avoid polluting the user's shell), and use blue instead of white for the report header and footer. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
affects koha_perl_deps.pl only, which is primarily only used turning install or trouble shooting. just changes colors, which are entirely cosmetic. Marking as Passed QA
patch pushed, please test
Included in 3.6 prior to 3.6.5.