Bug 6939 - DefaultClassificationSource not used in 942$2
Summary: DefaultClassificationSource not used in 942$2
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.8
Hardware: All All
: P5 - low normal (vote)
Assignee: Colin Campbell
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-09-29 13:31 UTC by Nicole C. Engard
Modified: 2013-12-05 20:01 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (1.23 KB, patch)
2012-06-18 10:32 UTC, Colin Campbell
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 6939 DefaultClassificationSource should be default in 942 (1.31 KB, patch)
2012-06-21 15:55 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-09-29 13:31:25 UTC
The DefaultClassificationSource preference sets the choice for the 952$2 but isn't used in the 942$2 - it should be used in both places.
Comment 1 Colin Campbell 2012-06-18 10:32:24 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2012-06-21 15:55:37 UTC
Created attachment 10414 [details] [review]
[SIGNED-OFF] Bug 6939 DefaultClassificationSource should be default in 942

A logic bug in the original code adding DefaultClassificationSource
caused the default not to be used (the last used value was used instead)
The bug was fixed in additem by bug 2398 but addbiblio's use
of the code was not fixed.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 3 Ian Walls 2012-06-25 17:57:01 UTC
Simple fix to logic, easy to read, marking Passed QA.
Comment 4 Paul Poulain 2012-06-28 07:30:04 UTC
(I haven't tested this patch, as I don't have classificationSource field / MARC21 in my test setup)