Bug 7022 - should sample_notices_message_attributes and sample_notices_message_transports move to mandatory?
Summary: should sample_notices_message_attributes and sample_notices_message_transport...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Installation and upgrade (web-based installer) (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) normal
Assignee: Henri-Damien LAURENT
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-13 11:59 UTC by MJ Ray (software.coop)
Modified: 2012-10-25 23:09 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Bug 7022: Move sample_notices* sql files from optional to mandatory (16.91 KB, patch)
2011-10-13 20:58 UTC, Katrin Fischer 		Details | Diff | Splinter Review
Bug 7022: Move sample_notices* sql files from optional to mandatory (16.95 KB, patch)
2011-10-14 09:41 UTC, MJ Ray (software.coop) 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description MJ Ray (software.coop) 2011-10-13 11:59:19 UTC 
sample_notices_message_attributes and sample_notices_message_transports
are currently in the optional folder, but some features don't work without them and there is no web user interface to add values to those tables.  Should they be moved to mandatory, at least until we have a user interface?

Could we get this into 3.8? It's not a feature change after all.
Comment 1 Katrin Fischer 2011-10-13 20:58:23 UTC Comment hidden (obsolete)
Comment 2 MJ Ray (software.coop) 2011-10-14 09:41:18 UTC 
Created attachment 5885 [details] [review]
Bug 7022: Move sample_notices* sql files from optional to mandatory

Sending messages  will not work correctly without correct data in sample_notice_message_transports
and sample_notice_message_attributes tables. There is no way to configure those tables in Koha.
SQL files should be in the mandatory part of the web installer.

Signed-off-by: MJ Ray <mjr@phonecoop.coop>
Comment 3 Ian Walls 2011-10-17 19:18:11 UTC 
Renames files correctly in git, and fixes a problem I've run into before; these values really are mandatory for Koha to work right!  Marking Passed QA
Comment 4 Chris Cormack 2011-10-18 02:59:08 UTC 
Pushed, please test
Comment 5 Irma Birchall 2011-11-04 05:32:40 UTC 
This is working fine. Closing @kohacon11 hackfest.