To see the bug: 1. Add a message from the checkout screen to the patron (as opposed to "other librarians"). 2. Turn on the AllowAllMessageDeletion preference. 3. Switch to another branch and view the patron's checkout screen. The message you added which was "to the patron" will lack a [Delete] link.
Created attachment 5875 [details] [review] Proposed fix The display of messages "to the patron" on the checkout screen lacked the same logic controlling messages "to other librarians," affecting conditions under which the [Delete] link would be shown. This match makes the two categories consistent with each other: A delete link will be shown if the logged in branch matches the branch where the message was set OR if AllowAllMessageDeletion is turned on.
Created attachment 5892 [details] [review] [SIGNED-OFF] Fix for Bug 7024 - Can't delete other library's messages with AllowAllMessageDeletion on The display of messages "to the patron" on the checkout screen lacked the same logic controlling messages "to other librarians," affecting conditions under which the [Delete] link would be shown. This match makes the two categories consistent with each other: A delete link will be shown if the logged in branch matches the branch where the message was set OR if AllowAllMessageDeletion is turned on. Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Template only change, easy to read. While this does introduce a string, it's the same string "[Delete]" that already exists in conditions of the code, so no new translation is required. Marking as Passed QA
Pushed please test