Bug 7033 - Make all strings translatable in marc21_field_007.tt
Summary: Make all strings translatable in marc21_field_007.tt
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) minor (vote)
Assignee: Frédérick Capovilla
QA Contact: Marcel de Rooy
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-14 20:26 UTC by Frédérick Capovilla
Modified: 2013-12-05 19:59 UTC (History)
4 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Make all strings translatable in marc21_field_007.tt (488.99 KB, patch)
2011-10-14 20:26 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
Make all strings translatable in marc21_field_007.tt (corrected) (612.01 KB, patch)
2011-10-18 14:59 UTC, Frédérick Capovilla
Details | Diff | Splinter Review
[SIGNED-OFF] Make all strings translatable in marc21_field_007.tt (612.41 KB, patch)
2011-10-19 19:44 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédérick Capovilla 2011-10-14 20:26:10 UTC Comment hidden (obsolete)
Comment 1 Frédérick Capovilla 2011-10-14 20:26:57 UTC
Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )
Comment 2 Katrin Fischer 2011-10-18 05:39:16 UTC
I have tested this on current master using following steps:

- apply patch
- perl translate update de-DE
- check for new strings, like "b- Braille"

I was not able to find the new strings in the updated po file. Not sure what the problem is, as the patch looks logical to me.
Comment 3 Frédérick Capovilla 2011-10-18 14:59:26 UTC Comment hidden (obsolete)
Comment 4 Katrin Fischer 2011-10-19 19:44:28 UTC
Created attachment 5994 [details] [review]
[SIGNED-OFF] Make all strings translatable in marc21_field_007.tt

http://bugs.koha-community.org/show_bug.cgi?id=7033

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Test plan:
- apply patch
- update po files using 'perl translate update <language-code>
- check po files for new strings from 007 plugin
- translate some / all of them
- update templates with changed po files 'perl translate install <language-code>
- verify 007 still works and got translated
Comment 5 Paul Poulain 2011-10-24 11:40:12 UTC
Updating version : This ENH could be in Koha 3.8
Comment 6 Paul Poulain 2011-10-25 15:05:52 UTC
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
Comment 7 Marcel de Rooy 2011-11-14 13:10:31 UTC
Lot of work. Did you run code over the code? ;)
If so, I could QA that for you..

QA Comment: This large patch only extensively covers the marc21 007 template. Looks good to me.
Comment 8 Paul Poulain 2011-11-17 16:11:09 UTC
Patch pushed, please test.
I also think it's a bug, not an ENH, so I set the severity accordingly and add to rel_3_6 to have chris_n applying the patch if needed

Note I haven't signed this patch, as I can't test it properly (my test DB is unimarc)
Comment 9 Chris Nighswonger 2011-11-17 22:47:55 UTC
In the future, please include "Bug XXXX" in the first line of the commit message.

Thanks,
Chris
3.4.x/3.6.x Release Maintainer
Comment 10 Jared Camins-Esakov 2012-05-23 12:47:51 UTC
This was included in the 3.6 branch prior to 3.6.4.