Bug 7038 - Contextual help is always in English
Summary: Contextual help is always in English
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: I18N/L10N (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Frédéric Demians
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-16 20:04 UTC by Frédéric Demians
Modified: 2013-12-05 19:53 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (2.42 KB, patch)
2011-10-16 20:09 UTC, Frédéric Demians
Details | Diff | Splinter Review
Proposed patch (2.46 KB, patch)
2011-10-16 20:13 UTC, Frédéric Demians
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7038 Contextual help is always in English (2.58 KB, patch)
2011-10-17 05:11 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2011-10-16 20:04:23 UTC
When another language than English is selected in pro interface, the software strings are in this language, but when clicking ?, on the top right of any page, the contextual help page which pop-up is always in English.
Comment 1 Frédéric Demians 2011-10-16 20:09:13 UTC Comment hidden (obsolete)
Comment 2 Frédéric Demians 2011-10-16 20:13:27 UTC Comment hidden (obsolete)
Comment 3 Katrin Fischer 2011-10-17 05:11:23 UTC
Created attachment 5909 [details] [review]
[SIGNED-OFF] Bug 7038 Contextual help is always in English

When another language than English is selected in pro interface, the software
strings are in this language, but when clicking ?, on the top right of any
page, the contextual help page which pop-up is always in English.

This patch fixes this bug and another side bug affecting editing contextual
help when not in English. help.pl script were in sync with the recently
patched/improved theme/language/template selection.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Context help now matches the selected template language.
Comment 4 Ian Walls 2011-10-17 19:16:26 UTC
Straight forward change, makes use of updated subroutines, replaces filehandle with variable.  Marking as Passed QA.
Comment 5 Chris Cormack 2011-10-18 03:02:39 UTC
Pushed, please test
Comment 6 Jared Camins-Esakov 2012-05-23 12:32:42 UTC
Seems to be working. Closing.