Bug 7042 - Improving cleanup_database.pl: handling quotes in a_session and interpreting sessdays parameter
Summary: Improving cleanup_database.pl: handling quotes in a_session and interpreting ...
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Command-line Utilities (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) minor
Assignee: Marcel de Rooy
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-17 09:45 UTC by Marcel de Rooy
Modified: 2012-10-25 23:09 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Patch (2.21 KB, patch)
2011-10-17 09:48 UTC, Marcel de Rooy 		Details | Diff | Splinter Review
Sign-off patch (2.22 KB, patch)
2011-10-20 08:20 UTC, Ian Bays 		Details | Diff | Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2011-10-17 09:45:01 UTC 
Improving the cleanup_database.pl script in two aspects:
1) In some cases CGI::Session seems to place quotes around the atime and ctime data in the a_session field. Two regexps now take this into account.
2) If the --sessdays parameter is used, the --sessions parameter is now implicitly enabled too.

With thanks to Ian Bays and Tom Hanstra.
Comment 1 Marcel de Rooy 2011-10-17 09:48:54 UTC Comment hidden (obsolete)
Comment 2 Ian Bays 2011-10-20 08:20:19 UTC 
Created attachment 6006 [details] [review]
Sign-off patch
Comment 3 Marcel de Rooy 2011-10-20 08:22:25 UTC 
(In reply to comment #2)
> Created attachment 6006 [details] [review]
> Sign-off patch

Great!
Comment 4 Ian Walls 2011-10-20 13:15:38 UTC 
Makes commandline too more flexible (quotes are regexed with ?, so all previous matches will continue, and new ones can be detected), and more intuitive (don't have to specify two params for sessions).  Marking as Passed QA.
Comment 5 Chris Cormack 2011-10-20 15:42:45 UTC 
Excellent work, pushed