Bug 7055 - NORMARC: Links and defaults for 008 position 15-17 and 35-37
Summary: NORMARC: Links and defaults for 008 position 15-17 and 35-37
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: MARC Bibliographic data support (show other bugs)
Version: Main
Hardware: All All
: P5 - low normal (vote)
Assignee: Magnus Enger
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-18 19:46 UTC by Magnus Enger
Modified: 2013-12-05 20:09 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7055 - NORMARC: Fix 008 position 15-17 and 35-37 (6.13 KB, patch)
2013-04-15 18:05 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 7055 - NORMARC: Fix 008 position 15-17 and 35-37 (6.03 KB, patch)
2013-04-15 18:07 UTC, Magnus Enger
Details | Diff | Splinter Review
Bug 7055 - NORMARC: Fix 008 position 15-17 and 35-37 (6.20 KB, patch)
2013-04-28 01:57 UTC, Chris Cormack
Details | Diff | Splinter Review
[PASSED QA] Bug 7055 - NORMARC: Fix 008 position 15-17 and 35-37 (6.33 KB, patch)
2013-04-28 13:32 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Magnus Enger 2011-10-18 19:46:52 UTC
NORMARC 008 position 15-17 should link to http://www.nb.no/baser/landekoder/ and have "no" as default. 

NORMARC 008 position 35-37 should link to http://www.nb.no/baser/sprakkoder/ and have "nob" as default.
Comment 1 Paul Poulain 2011-10-25 15:05:43 UTC
Bug versionned for master. entries will be made against rel_3_8 once the patch has been applied (see thread about that on koha-devel yesterday)
Comment 2 Magnus Enger 2013-04-15 18:05:48 UTC Comment hidden (obsolete)
Comment 3 Magnus Enger 2013-04-15 18:07:08 UTC Comment hidden (obsolete)
Comment 4 Chris Cormack 2013-04-28 01:57:43 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2013-04-28 13:32:41 UTC
Created attachment 17772 [details] [review]
[PASSED QA] Bug 7055 - NORMARC: Fix 008 position 15-17 and 35-37

This patch does several things:
- Set the default for 008/15-17 to "no " (yes, there is space at the end)
- Link from 008/15-17 in the value builder to NORMARC country codes
- Set the default for 008/35-37 to "nor" (by setting the
  DefaultLanguageField008 syspref)
- Link from 008/35-37 in the value builder to NORMARC language codes
- Fix a missing <tr> around field 35-37

To reproduce:
- Run through the Web-installer in Norwegian and choose NORMARC as
  the MARC flavour
- Go to Home > Cataloging > Add MARC record and add a new record
- Click in the field for 008. The default should look like:
  130415t        xxu||||| |||| 00| 0 eng d
                 ^^^                 ^^^
- Reload the page and open the value builder for 008. Problems:
  - The text for 15-17 links to MARC21 country codes
  - The default for 15-17 is xxu
  - The text for 35-37 links to MARC21 language codes
  - The default for 35-37 is eng
  - If you choose e.g. "Monografier" in the top dropdown then click
    on "OK" the window does not close

To test:
- Apply the patch and run through the Web-installer again, selecting
  Norwegian and NORMARC
- Go to Home > Cataloging > Add MARC record and add a new record
- Click in the field for 008. The default should look like:
  130415t        no ||||| |||| 00| 0 nor d
                 ^^^                 ^^^
- Reload the page and open the value builder for 008.
- Check that...
  - The default for 15-17 is "no " (with a space at the end)
  - The link goes to NORMARC country codes
  - The default for 35-37 is "nor"
  - The link goes to NORMARC language codes
- Select something from the top dropdown and click "OK". Check that the
  window closes and that the values that are entered into the 008 field
  matches what you chose in the popup window.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>

Trusing Magnus is right, so testing for any regressions mainly, all good

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Only changes NORMARC specific plugin and system preferences
files. Changes all seem logical to me.
Comment 6 Jared Camins-Esakov 2013-05-01 11:45:41 UTC
This patch has been pushed to master and 3.12.x.
Comment 7 Chris Cormack 2013-05-09 07:12:22 UTC
Pushed to 3.10.x will be in 3.10.6