Created attachment 6012 [details] [review] Use MARCAuthorityControlField008 in AddAuthority for empty 008s The old default value for field 008 in AddAuthority didn't have the correct length, which could potentially cause data corruptions. Since the MARCAuthorityControlField008 preference was recently added in BUG4839, I think it would be a good idea to also use it in AddAuthority for authorities without 008 MARC fields. Patch attached.
Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )
The BiblioAddAuthorities subroutine seems to always send authority records to AddAuthority without a 008 field. It can be used in the test plan. Test plan (MARC21 only) : * Make sure a valid value is set in the MARCAuthorityControlField008 system preference. * Activate the BiblioAddsAuthorities system preference. * Create a new bibliographic record with a manually entered authority values. (for example, "Bob" in 650$a) * Go to the details page of the authority that should have been created by BiblioAddsAuthorities. (To find it, go in the MARC view of the biblio record we just created, and click on the "Auth" link next to the authority value) * Check the value of field 008 for this authority. The value of the MARCAuthorityControlField008 system preference should have been used.
Created attachment 6498 [details] [review] Use MARCAuthorityControlField008 in AddAuthority for empty 008s The old default value for field 008 didn't have the correct length, which could potentially cause data corruptions. Uses the MARCAuthorityControlField008 preference added by BUG4839. http://bugs.koha-community.org/show_bug.cgi?id=7072 Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Provided you've set your sysprefs properly, this works as expected. I also confirmed that there is no change to behavior in the authorities editor.
QA: Code looks good. Hardcoded value (when pref is empty) is the same as in marc21_field_008_authorities.pl. Marking as Passed QA.
patch pushed, please test
There have been no further reports of problems so I am marking this bug resolved.