There are mails generated when you mark something as available or when you mark it as rejected. Every time you change the status between those too, the patron will get a notification. The messages are correctly written into the message_queue table. BUT: The placeholders for fields from suggestions do not work. The patron name showed up correctly. For testing purposes I added all fields from suggestions to my notices: suggestionid <<suggestions.suggestionid>> suggestedby <<suggestions.suggestedby>> suggesteddate <<suggestions.suggesteddate>> managedby <<suggestions.managedby>> manageddate <<suggestions.manageddate>> acceptedby <<suggestions.acceptedby>> accepteddate <<suggestions.accepteddate>> rejectedby <<suggestions.rejectedby>> rejecteddate <<suggestions.rejecteddate>> STATUS <<suggestions.STATUS>> note <<suggestions.note>> author <<suggestions.author>> title <<suggestions.title>> copyrightdate <<suggestions.copyrightdate>> publishercode <<suggestions.publishercode>> date <<suggestions.date>> volumedesc <<suggestions.volumedesc>> publicationyear <<suggestions.publicationyear>> place <<suggestions.place>> isbn <<suggestions.isbn>> mailoverseeing <<suggestions.mailoverseeing>> biblionumber <<suggestions.biblionumber>> reason <<suggestions.reason>> budgetid <<suggestions.budgetid>> branchcode <<suggestions.branchcode>> collectiontitle <<suggestions.collectiontitle>> itemtype <<suggestions.itemtype>> quantity <<suggestions.quantity>> currency <<suggestions.currency>> price <<suggestions.price>> total <<suggestions.total>> None of those showed up in my mails. Without at least title and author the mails are quite useless.
*** Bug 7212 has been marked as a duplicate of this bug. ***
Created attachment 6639 [details] [review] Proposed Patch In parseletter_sth, the suggestions table was defined twice. The first time (which is the only definition to get called, as it matches first then exists), defined the primary search keys as borrowernumber and biblionumber. This is incorrect; the only usage of the suggestions table tokens is with suggestionid as the key. This is defined further down the if/then chain. This patch removes the erroneous sth query definition. To test: 1. Place a suggestion with a patron account with a configured email you can access 2. Approve or reject it 3. Verify the message you receive contains suggestion tokens (like title, author and reason)
Created attachment 6657 [details] [review] [SIGNED-OFF] Bug 7093: placeholds for suggestion table not working in notices In parseletter_sth, the suggestions table was defined twice. The first time (which is the only definition to get called, as it matches first then exists), defined the primary search keys as borrowernumber and biblionumber. This is incorrect; the only usage of the suggestions table tokens is with suggestionid as the key. This is defined further down the if/then chain. This patch removes the erroneous sth query definition. To test: 1. Place a suggestion with a patron account with a configured email you can access 2. Approve or reject it 3. Verify the message you receive contains suggestion tokens (like title, author and reason) Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Suggestion mails for accepted, rejected and ordered look good now. I couldn't test the suggestion mail AVAILABLE (bug 7096), but assuming this would work too.
Assigning to Marcel for QA, since I wrote
QA comment: small patch, obvious bug, passed QA patch pushed, please test
Included in 3.6 prior to 3.6.5.