Created attachment 6110 [details] screenshot When hiding the filters on the funds page using the link 'filters' navigation and main part of the page crash together.
Created attachment 7260 [details] [review] Proposed patch
To test to to Budgets. Click on a budget to get to its funds. Click on the 'Filters' link above the Fund Filters input form.
Created attachment 7584 [details] [review] [SIGNED-OFF] Bug 7114: Fixes the Funds' page display after the Filter link is clicked. On the funds page there is a Fund Filters form and a menu underneath this form. When the form is hidden the contents of the page shift to the left overlapping the menu. The menu underneath the fund filters form must have been a later edition. This patch removes the line of javascript that shifts the contents of the page after the form is hidden. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch fixes the broken Layout when clicking on 'Filters'. I am a bit confused by the link. I think it should toggle between different descriptions and perhaps even hide all of the left navigation. This way the funds table would get more room for display.
I think the menus under the Fund Filters box were a later addition. We could either hide the menu and make the display move all the way to the left, or we could leave the menus and just make the display scoot over to the menus.
Not sure how 'make the display scoot over to the menus' would look like. Do you mean diplaying the fund tabel below the text menu?
I mean retaining the current menu of links, but moving the display as far to the left as possible without the menu overlapping the display when the form is hidden. After you explained the purpose of hiding the filters, I think my preference would be to not apply the current patch and send another patch that hides the form as well as the menu when the 'filters' link is clicked.
I only wondered becaue the function didn't make much sense to me as it is now. I think you are right - the navigation links were probably added later, which explains why the display problem was not spotted too. If you want to do another patch I will sign-off on it, but I think the patch as is is already an improvement. Perhaps you can toggle the link description too? (Hide/Show filters/navigation?
Correctly fixes filter-hiding CSS. Marking as Passed QA.
Removing a hardcoded styling is always good. This should never have been in the templates in fact !
This fix was included in the 3.6.x branch prior to 3.6.4.