Bug 7118 - Any and empty entries in pull downs for suggestion filters
Summary: Any and empty entries in pull downs for suggestion filters
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: Main
Hardware: All All
: P1 - high trivial (vote)
Assignee: Bugs List
QA Contact: Bugs List
URL: /cgi-bin/koha/suggestion/suggestion.p...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-10-31 00:33 UTC by Katrin Fischer
Modified: 2015-12-03 22:00 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7118: Remove 'any' from pull downs in acquisitions (3.74 KB, patch)
2011-10-31 00:46 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Katrin Fischer 2011-10-31 00:33:19 UTC
The filters on the suggestion page show 'Any' and an empty entry for the filters 'Suggested by', 'Accepted by' and 'Managed by'.

Both do the same. It should only be 'Any' or an empty entry, but not both.
Comment 1 Katrin Fischer 2011-10-31 00:46:50 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-11-03 02:50:59 UTC
Managed by and suggested by work, but I have no blank entry for Suggested by.
Comment 3 Katrin Fischer 2011-11-03 07:37:45 UTC
Hi Chris, 

did you mean 'suggested by'? My list looks like this:

<li><label for="suggestedby"> Suggested By:</label>
<select id="suggestedby" name="suggestedby">
  <option value="">Any</option>
  <option value="0"></option>
  <option value="2">Katrin, Fischer</option>

So my blank entry came from the 0 value, but there is indeed no value="" line.
Investigating...
Comment 4 Katrin Fischer 2011-11-03 07:50:36 UTC
Ok, I see now what's going on here:
The empty line shows when you have at least one suggestion, where the value for the column is null. For 'suggested by' this should never happen, so there is no empty line. Not sure how I managed to do that - might be a bug or from testing something else. The 'Any' lines are actually needed.

So the solution to the confusing list is invalid.
Comment 5 Katrin Fischer 2011-11-03 07:54:14 UTC
Any and the empty lines have both value="". 
So both settings will search for all entries and there is currently no way to search for unmanaged or unaccepted entries.
Leaving the bug open.
Comment 6 Jonathan Druart 2015-03-26 16:00:21 UTC
Looks good now, please reopen if I am wrong.