Bug 7125 - can't change tag in frameworks
Summary: can't change tag in frameworks
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: master
Hardware: All All
: P5 - low normal (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-01 15:12 UTC by Nicole C. Engard
Modified: 2014-12-07 20:07 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: Small patch
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
edit framework tag (24.85 KB, image/png)
2011-11-01 15:12 UTC, Nicole C. Engard
Details
Bug 7125 - can't change tag in frameworks (3.11 KB, patch)
2014-04-23 15:05 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7125 - can't change tag in frameworks (3.20 KB, patch)
2014-04-23 15:42 UTC, Bernardo Gonzalez Kriegel
Details | Diff | Splinter Review
[PASSED QA] Bug 7125 - can't change tag in frameworks (3.33 KB, patch)
2014-04-26 13:12 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-11-01 15:12:23 UTC
see attached. When I go to edit a framework and change the tag number it looks like I'm able to, but when I hit save my changes aren't saved and no error message is generated. If this tag number isn't editable it shouldn't appear as if it is.
Comment 1 Nicole C. Engard 2011-11-01 15:12:37 UTC
Created attachment 6132 [details]
edit framework tag
Comment 2 Owen Leonard 2013-04-02 01:48:35 UTC
As far as I can tell this bug is in master too, as of 3.12 beta2
Comment 3 Owen Leonard 2014-04-23 15:05:00 UTC Comment hidden (obsolete)
Comment 4 Bernardo Gonzalez Kriegel 2014-04-23 15:42:00 UTC Comment hidden (obsolete)
Comment 5 Katrin Fischer 2014-04-26 13:12:26 UTC
Created attachment 27654 [details] [review]
[PASSED QA] Bug 7125 - can't change tag in frameworks

When you edit an existing tag in a MARC framework the form makes it
appear as if you can change the tag number when in fact you cannot. This
patch changes the template so that the tag number does not appear as an
editable form field during the edit process.

To test, apply the patch and open an existing MARC framework in
Adminstration -> MARC bibliographic framework.

- Choose an existing tag from the list and click 'Edit.'
- The line labeled "Tag" should display the tag as text.
- Making a change to any of the tag's details should work correctly.
- Return to the list of the MARC framework's tags.
- Click 'New tag.'
- The line labeled "Tag" should display a blank form field.
- Create a new tag and confirm that it saves correctly.

Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Work as describes, on edit and new.
No koha-qa errors

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Work as described, template change only.
Checked editing and adding tags.
Comment 6 Galen Charlton 2014-04-28 17:43:07 UTC
Pushed to master.  Thanks, Owen!