Bug 7135 - in addbiblio, make save button floating to have it on always on screen
Summary: in addbiblio, make save button floating to have it on always on screen
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Cataloging (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Owen Leonard
QA Contact: Bugs List
URL:
Keywords:
Depends on:
Blocks: 2710
  Show dependency treegraph
 
Reported: 2011-11-01 20:29 UTC by Nicole C. Engard
Modified: 2013-12-05 19:59 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (4.82 KB, patch)
2011-11-03 18:59 UTC, Owen Leonard
Details | Diff | Splinter Review
Bug 7135: Save button options (4.83 KB, patch)
2011-12-06 22:56 UTC, Chris Cormack
Details | Diff | Splinter Review
[Signed Off] Fix for Bug 7135: Save button options (5.03 KB, patch)
2011-12-06 23:00 UTC, Liz Rea
Details | Diff | Splinter Review
Follow-up fix (1.56 KB, patch)
2011-12-13 19:41 UTC, Owen Leonard
Details | Diff | Splinter Review
Signed off follow up fix for patch. (1.52 KB, patch)
2011-12-13 20:58 UTC, Duncan
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-11-01 20:29:48 UTC
would be nice if the save button in cataloging was at the top and the bottom - or better yet is always on the screen - floating as you scroll.
Comment 1 Owen Leonard 2011-11-03 18:59:29 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2011-11-03 19:07:21 UTC
How it should look: http://screencast.com/t/0gBcTT6OKQ

Tested successfully so far in:

FF7 / Win7
Chrome 15 / Win7
IE8 / Win7
Opera 11 / Win7
Safari 5 / Win7

Chrome 14 / Ubuntu 11.10
Firefox 7 / Ubuntu 11.10
Comment 3 Owen Leonard 2011-11-18 18:29:03 UTC
Not exactly a license, but the author responds "This plugin is as free as fresh air. Feel free to use it anywhere."
Comment 4 Chris Cormack 2011-12-03 00:54:02 UTC
I think that is pretty close to the WTFPL http://en.wikipedia.org/wiki/WTFPL 

:)
Comment 5 Chris Cormack 2011-12-06 22:55:53 UTC
Signing off, works in 11.10 Chromium 17 as well
Comment 6 Chris Cormack 2011-12-06 22:56:47 UTC Comment hidden (obsolete)
Comment 7 Liz Rea 2011-12-06 23:00:37 UTC Comment hidden (obsolete)
Comment 8 Liz Rea 2011-12-06 23:02:28 UTC
And Firefox 8.0.1

(In reply to comment #7)
> Created attachment 6627 [details] [review]
> [Signed Off] Fix for Bug 7135: Save button options
> 
> This patch adds a jQuery plugin which will cause
> an element to remain "fixed" at the top of the
> screen if it would otherwise scroll up out of
> view.
> 
> I submit this patch for TESTING ONLY because
> the plugin was not posted with explicit licensing.
> I'm waiting to hear back from the author.
> 
> Signed-off-by: Liz Rea <wizzyrea@gmail.com>
> I tested this on Chrome OSX
> saving works
> changing framework works
> scrolling works, obviously.
> tabbing through the records works
> z39 button works as expected
Comment 9 Paul Poulain 2011-12-13 17:03:07 UTC
QA comment:
* tested, works fine
* license question solved, i've updated the patch comment to reflect that

passed QA

patch pushed, please test

chris_n = maybe worth for 3.6, but beware it changes addbiblio behaviour, that can surprise users !
Comment 10 Paul Poulain 2011-12-13 17:09:26 UTC
oups... failed QA detected just before pushing the patch !!!

* addbiblio
* open the "More" menu

=> the menus are BELOW the save button, making Reports & Serial unreachable !
Comment 11 Owen Leonard 2011-12-13 19:41:12 UTC Comment hidden (obsolete)
Comment 12 Duncan 2011-12-13 20:58:16 UTC
Created attachment 6761 [details] [review]
Signed off follow up fix for patch.
Comment 13 Paul Poulain 2011-12-14 14:54:23 UTC
follow-up patch pushed, thanks for the quick fix !
Comment 14 Jared Camins-Esakov 2012-05-23 12:59:19 UTC
This fix was included in the 3.6.x branch prior to 3.6.4.