Bug 7139 - Log circulation messags
Summary: Log circulation messags
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Reports (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Chris Cormack
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-02 01:19 UTC by Chris Cormack
Modified: 2013-12-05 19:57 UTC (History)
5 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Bug 7139 : Log addition and deletion of circulation messages (1.53 KB, patch)
2011-11-02 02:01 UTC, Chris Cormack
Details | Diff | Splinter Review
Signed-Off Bug 7139 : Log addition and deletion of circulation messages (1.58 KB, patch)
2011-11-04 07:56 UTC, Brendan Gallagher
Details | Diff | Splinter Review
Signed patch (text revised) (1.66 KB, patch)
2011-12-12 08:41 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Cormack 2011-11-02 01:19:48 UTC
Work To Be Done: 

* Modify borrower log to keep a record of the addition and removal of circulation messages 
  -  Need to track the action performed (add or delete) 
  -  Need to track the text of the message 
  -  Need to track the librarian doing the adding/removing 
  -  Need to track the date and time of each action 


How to test: 

* Add a circulation message on check out screen 
  -  Check the logs to see if the message is recorded 
* Remove the circulation message 
  -  Check the logs to see if the message has been removed
Comment 1 Chris Cormack 2011-11-02 02:01:49 UTC Comment hidden (obsolete)
Comment 2 Brendan Gallagher 2011-11-04 07:56:21 UTC Comment hidden (obsolete)
Comment 3 Ian Walls 2011-11-04 08:14:20 UTC
Good clean code, but the second param passed to logaction (actionname) is traditionally in all caps, not regular text (and never with spaces).  This is probably safe, but for consistency, I'd prefer:  ADDMESSAGE and DELMESSAGE.

Community feedback: am I been too much of a stickler here?
Comment 4 Marcel de Rooy 2011-12-12 08:41:39 UTC
Created attachment 6714 [details] [review]
Signed patch (text revised)
Comment 5 Paul Poulain 2011-12-13 17:15:50 UTC
QA comment:
* problem pointed by ian addressed by Marcel revised patch, 
* works well,
* perlcritic fails, but it was failing before this patch

passed QA

patch pushed, please test
Comment 6 Jared Camins-Esakov 2012-05-23 12:01:48 UTC
Included in 3.6 prior to 3.6.5.