Work To Be Done: * Modify borrower log to keep a record of the addition and removal of circulation messages - Need to track the action performed (add or delete) - Need to track the text of the message - Need to track the librarian doing the adding/removing - Need to track the date and time of each action How to test: * Add a circulation message on check out screen - Check the logs to see if the message is recorded * Remove the circulation message - Check the logs to see if the message has been removed
Created attachment 6138 [details] [review] Bug 7139 : Log addition and deletion of circulation messages
Created attachment 6182 [details] [review] Signed-Off Bug 7139 : Log addition and deletion of circulation messages Signed-Off
Good clean code, but the second param passed to logaction (actionname) is traditionally in all caps, not regular text (and never with spaces). This is probably safe, but for consistency, I'd prefer: ADDMESSAGE and DELMESSAGE. Community feedback: am I been too much of a stickler here?
Created attachment 6714 [details] [review] Signed patch (text revised)
QA comment: * problem pointed by ian addressed by Marcel revised patch, * works well, * perlcritic fails, but it was failing before this patch passed QA patch pushed, please test
Included in 3.6 prior to 3.6.5.