Bug 7160 - paying fines throws error
Summary: paying fines throws error
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Circulation (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) critical (vote)
Assignee: Kyle M Hall
QA Contact: Jonathan Druart
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-04 19:31 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
4 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed Patch (959 bytes, patch)
2011-11-05 03:30 UTC, Ian Walls
Details | Diff | Splinter Review
Bug 7160: paying fines throws error (1014 bytes, patch)
2011-11-05 07:22 UTC, Brendan Gallagher
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-11-04 19:31:49 UTC
Watch this video: http://www.screencast.com/t/900jXRZF  When you pay a line item you get an error, but it actually does pay the fine.
Comment 1 Nicole C. Engard 2011-11-04 19:32:47 UTC
Sorry - the error is:

Software error:

Undefined subroutine &C4::Accounts::ReturnLostItem called at
/home/koha/kohaclone/C4/Accounts.pm line 220.
Comment 2 Ian Walls 2011-11-05 03:30:53 UTC Comment hidden (obsolete)
Comment 3 Brendan Gallagher 2011-11-05 07:22:08 UTC
Created attachment 6220 [details] [review]
Bug 7160: paying fines throws error

The call to ReturnLostItem in C4/Accounts was not properly namespaced to
come from C4::Circulation.  That prefix is added to the call.

To test:

Pay a fine, and confirm the error disappears (and the fines is still paid)

Signed-off-by: Brendan <brendan@bywatersolutions.com>
Comment 4 Paul Poulain 2011-11-18 21:27:57 UTC
is it just me or the screencast in Nicole Description is just a black screen (with the Jing header) ?

QA comment: I can't reproduce the problem before applying the patch. There should be some specific things to do that I can't find.
Comment 5 Nicole C. Engard 2011-11-20 00:38:29 UTC
Hmmm, the video is playing for me.  Can someone else tell me what they see?
Comment 6 Paul Poulain 2011-12-07 10:32:35 UTC
seems I have some problems watching films on my Ubuntu. Sometimes it works, sometimes not. Don't worry, it must be me.
Comment 7 Paul Poulain 2011-12-14 13:41:54 UTC
QA comment: tiny patch, nothing to say (works, fixes the problem, 1 line patch)

Patch pushed, please test