Modified Open Library JS to: 1. Use jscmd=data instead of default, this provides ebooks availability information. This will allow us to display read/borrow/checkedout icons 2. Show larger image in opac-detail page 3. Show read/borrow/checked-out status in opac-detail page below the image
*** Bug 6672 has been marked as a duplicate of this bug. ***
Created attachment 6221 [details] [review] Open Library - Larger image, Read, borrow and checked-out status
Created attachment 6227 [details] [review] Bug-7161 Open Library - Larger image, Read, borrow and checked-out status To test: 1. go into system administration and search for "cover" 2. change "OpenLibraryCovers" to "add" and all other to "don't show" 3. verify that opac search results have small covers, while detail page has big ones 4. (optional) find book which is available for reading (and not borrowed!) on Open Library and change ISBN on one of your books to test Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org>
QA Comments: Thanks for your work. Could you clarify/modify please following points: I did not find an example on short notice for ebooks with availability information/icon. There is a new function keys; but I couldn't see a call for it. Same for get_cover; only call is in comments. Some further questions on the code: A console debug message is still present. A regex call before creating Preview div has been eliminated; the reason for doing that is not made clear in this report. Can imagine that is was not really needed. A variable a is filled with element a and modified href. But later on an element a is manually appended with yet another book.url. Not clear?
I'd like to see the larger open library images in 3.8 - should this patch be broken in to parts so that such a simple fix can be pushed while the other parts are worked on?
Created attachment 9865 [details] [review] Bug-7161 Open Library - Larger image, Read, borrow and checked-out status To test: 1. go into system administration and search for "cover" 2. change "OpenLibraryCovers" to "add" and all other to "don't show" 3. verify that opac search results have small covers, while detail page has big ones Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Addressing M. de Rooy's concerns * remove console.log * removed some comments that looked like debug code? * remove ebook display - I couldn't get it to work properly, and we want the bigger images. So it's gone. * remove get_cover
Created attachment 9873 [details] [review] Bug-7161 Open Library - Larger image, Read, borrow and checked-out status To test: 1. go into system administration and search for "cover" 2. change "OpenLibraryCovers" to "add" and all other to "don't show" 3. verify that opac search results have small covers, while detail page has big ones Signed-off-by: Dobrica Pavlinusic <dpavlin@rot13.org> Addressing M. de Rooy's concerns * remove console.log * removed some comments that looked like debug code? * remove ebook display - I couldn't get it to work properly, and we want the bigger images. So it's gone. * remove get_cover Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Marcel, you already made a 1st QA, so I let this one for you. Looking at the code I don't see anything wrong
(In reply to comment #8) > Marcel, you already made a 1st QA, so I let this one for you. Looking at the > code I don't see anything wrong Will be looking at this shortly..
Created attachment 10539 [details] [review] Patch for 7161 Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> June 27, 2012: Removing unused function keys from openlibrary.js.
Created attachment 10540 [details] [review] Followup for 7161 Only whitespace changes to fix indentation after tab removal.
Earlier comments have been implemented. Did some minor corrections myself on unused function and whitespace. Marking as Passed QA now.
Created attachment 11312 [details] tini tiny cover on search results My bug was marked a duplicate of this - but this didn't fix my my bug which was that the open library images are too small to see on the search results.
The images on the search results for open library are still pretty tiny - can we update those to be somewhere between the size that's there now and the size that's on the detail page?
Bug 9660 addresses the search results issue. Nicole