Bug 7164 - add Koha history timeline tab to 'About' page
Summary: add Koha history timeline tab to 'About' page
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: 3.6
Hardware: All All
: P3 enhancement (vote)
Assignee: Mason James
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-05 10:22 UTC by Mason James
Modified: 2012-10-25 23:10 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot (137.04 KB, image/png)
2011-11-05 10:22 UTC, Mason James
Details
Bug 7164 - add Koha history timeline tab to 'About' page (6.63 KB, patch)
2011-11-05 10:30 UTC, Mason James
Details | Diff | Splinter Review
Bug 7164 - add Koha history timeline tab to 'About' page (5.82 KB, patch)
2011-11-05 10:40 UTC, Mason James
Details | Diff | Splinter Review
Screeshot of a problem (15.74 KB, image/png)
2011-12-02 14:43 UTC, Owen Leonard
Details
Bug 7164 : Follow up fixing formatting in docs/history.txt (1.00 KB, patch)
2011-12-02 20:26 UTC, Chris Cormack
Details | Diff | Splinter Review
Signed-off patch (6.73 KB, patch)
2011-12-05 20:27 UTC, Owen Leonard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2011-11-05 10:22:43 UTC
Created attachment 6224 [details]
screenshot

this enhancement reads the docs/history.txt file, and displays it in the staff 'About' page.
Comment 1 Mason James 2011-11-05 10:30:55 UTC Comment hidden (obsolete)
Comment 2 Mason James 2011-11-05 10:40:44 UTC Comment hidden (obsolete)
Comment 3 Mason James 2011-11-05 10:44:06 UTC
(In reply to comment #1)
> Created attachment 6225 [details] [review]
> Bug 7164 - add Koha history timeline tab to 'About' page

oops, made a little typo on that 1st commit
Comment 4 Owen Leonard 2011-12-02 14:43:50 UTC Comment hidden (obsolete)
Comment 5 Chris Cormack 2011-12-02 20:13:06 UTC
Actually Owen thats a problem with the doc/history.txt someone has used spaces instead of tabs, if we fix that, it will fix the display here. 
Ill submit a follow up for that and we can set it back to needs sign off
Comment 6 Chris Cormack 2011-12-02 20:26:59 UTC Comment hidden (obsolete)
Comment 7 Owen Leonard 2011-12-05 20:27:41 UTC
Created attachment 6585 [details] [review]
Signed-off patch

I hope it's okay I signed off and included one minor edit: Adding an html filter ("|html") to the output of the history description for the sake of HTML validity.
Comment 8 Paul Poulain 2011-12-14 14:34:29 UTC
QA comment : 
* perlcritic was failing because of open() syntax
* there was a small conflict with history.txt

I fixed both of those problems, works fine

Patch pushed, please test
Comment 9 Mason James 2012-04-22 12:26:12 UTC
(In reply to comment #8)
> QA comment : 
> * perlcritic was failing because of open() syntax
> * there was a small conflict with history.txt
> 
> I fixed both of those problems, works fine
> 
> Patch pushed, please test

tested ok :)  

ready for inclusion 3.8?
Comment 10 Katrin Fischer 2012-04-22 12:36:52 UTC
Hi Mason - it's already in master and has been for a while :)