Bug 7186 - add new 'Koha Stats' tab to 'About' page
Summary: add new 'Koha Stats' tab to 'About' page
Status: CLOSED INVALID
Alias: None
Product: Koha
Classification: Unclassified
Component: About (show other bugs)
Version: Main
Hardware: All All
: PATCH-Sent (DO NOT USE) enhancement (vote)
Assignee: Mason James
QA Contact:
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-06 08:56 UTC by Mason James
Modified: 2015-12-03 22:00 UTC (History)
3 users (show)

See Also:
Change sponsored?: Sponsored
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
screenshot (105.11 KB, image/png)
2011-11-06 08:56 UTC, Mason James
Details
Bug 7186 - add new 'Koha Stats' tab to 'About' page (5.33 KB, patch)
2011-11-06 09:24 UTC, Mason James
Details | Diff | Splinter Review
Bug 7186 - add new 'Koha Stats' tab to 'About' page (4.54 KB, patch)
2012-06-09 10:35 UTC, Kyle M Hall
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Mason James 2011-11-06 08:56:11 UTC
Created attachment 6240 [details]
screenshot

this enhancement adds some statistics (and links) from Koha's Ohloh.net page, to the Koha staff 'About' page
Comment 1 Mason James 2011-11-06 09:24:50 UTC Comment hidden (obsolete)
Comment 2 Owen Leonard 2011-12-02 15:12:01 UTC
In my opinion this information is not necessary to display. It seems more promotional than informational, and anyway I'm not sure we should be pulling data directly from a third-party source for this.
Comment 3 Ian Walls 2011-12-02 15:17:03 UTC
Not a fan of hard-coded third party integration, myself.  I prefer to see things like that wrapped in system preferences (like our Enhanced Content area), liked to using specific syspref code (like Facebook/Twitter API calls in OPACMySummaryHTML) or handled through external cronjobs.

Could this whole new tab be added with JQuery?
Comment 4 Ian Walls 2011-12-02 15:22:44 UTC
Magnus points out that the Facebook/Twitter API calls are not an explicit part of OPACMySummaryHTML.  They're entirely optional, made possible by the parsing of the BIBLIONUMBER token (I'm a little loopy today, so I'm sorry if I didn't make that clear)
Comment 5 Mason James 2011-12-03 00:07:39 UTC
(In reply to comment #2)
> In my opinion this information is not necessary to display. 

agreed, its not necessary - is that enough reason to not allow the patch to be committed?
is the 'OPAC cover-images' feature necessary, too?

> It seems more
> promotional than informational, 

the info is *both*  promotional and informational, thats why i did the patch...

> and anyway I'm not sure we should be pulling
> data directly from a third-party source for this.

why not? we pull 'data directly from a third-party source'  when fetching cover images
fyi: ohloh's 'terms and conditions' allow this specific usage

any other problems with the patch? :)
Comment 6 Mason James 2011-12-03 00:26:47 UTC
(In reply to comment #3)
> Not a fan of hard-coded third party integration, myself.  I prefer to see
> things like that wrapped in system preferences (like our Enhanced Content
> area), liked to using specific syspref code (like Facebook/Twitter API calls in
> OPACMySummaryHTML)  or handled through external cronjobs.

Ian, i'm prepared to add a on/off display syspref to this, if you would accept it

but any more effort than that? i'll just let this patch die...
Comment 7 Katrin Fischer 2011-12-03 05:41:04 UTC
Third party integration is kind of a sensitive issue and I would like to see an option to turn this off, with off being the default setting. Perhaps the 'off' version can show a link to the stats somewhere in the about page.
Comment 8 Katrin Fischer 2011-12-21 07:40:04 UTC
There is some controversial disscussion about this bug. 
Patch does currently not apply to master:

Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y
Applying: Bug 7186 - add new 'Koha Stats' tab to 'About' page
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/css/staff-global.css
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/about.tt
Failed to merge in the changes.
Patch failed at 0001 Bug 7186 - add new 'Koha Stats' tab to 'About' page
When you have resolved this problem run "git am --resolved".
If you would prefer to skip this patch, instead run "git am --skip".
To restore the original branch and stop patching run "git am --abort".
Comment 9 Kyle M Hall 2012-06-09 10:35:10 UTC
Created attachment 10004 [details] [review]
Bug 7186 - add new 'Koha Stats' tab to 'About' page
Comment 10 Francois Charbonnier 2012-06-10 10:20:48 UTC
Patch tested :
* the stastistic tab appears well 
* but the syspref interface css looks broken.

Question :
Is there a syspref to turn this stat tab on/off?
Comment 11 Katrin Fischer 2012-06-10 10:26:27 UTC
I would really like to see an option to have this configurable (see comment 7). It's a nice feature, but might introduce some problems for data privacy.
Comment 12 Jared Camins-Esakov 2013-01-02 02:24:24 UTC
Resetting to ASSIGNED since there are serious privacy concerns with this patch. A better option for this functionality would be to provide a script with which the RM can generate the required statistics at release time.
Comment 13 Mason James 2014-12-03 06:49:16 UTC
(In reply to Jared Camins-Esakov from comment #12)
> Resetting to ASSIGNED since there are serious privacy concerns with this
> patch. A better option for this functionality would be to provide a script
> with which the RM can generate the required statistics at release time.

this feature is not really needed

i think this bug can be closed