Bug 7193 - can't remove end date from subscriptions
Summary: can't remove end date from subscriptions
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Serials (show other bugs)
Version: 3.6
Hardware: All All
: P3 critical (vote)
Assignee: Duncan
QA Contact: Ian Walls
URL: cgi-bin/koha/serials/subscription-add...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-08 16:15 UTC by Nicole C. Engard
Modified: 2019-06-27 09:24 UTC (History)
3 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
left side - no way to remove the date and hit save (50.31 KB, image/png)
2011-11-08 19:12 UTC, Nicole C. Engard
Details
right side - i can delete (35.84 KB, image/png)
2011-11-08 19:13 UTC, Nicole C. Engard
Details
Fix to make date obviously editable - bug 7193 (3.79 KB, patch)
2011-12-19 00:48 UTC, Duncan
Details | Diff | Splinter Review
[SIGNED-OFF] Fix to make date obviously editable - bug 7193 (4.06 KB, patch)
2011-12-19 05:43 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-11-08 16:15:21 UTC
There is no way to remove the end date from subscriptions. If you enter it by mistake you can't change it - or if you enter it and change your mind - same deal.  There should be a way to remove the end date.

Nicole
Comment 1 Colin Campbell 2011-11-08 17:18:51 UTC
You can remove the enddate in subscription edit and that removes it from the record. But if you display the subscription and there is no enddate present it will calculate when the subscription expires and display that as end date.

Strikes me that theres a bit on inconsistency in field naming and function here (and elsewhere in serials) which is not at all helpful to the user.
Comment 2 Nicole C. Engard 2011-11-08 19:08:47 UTC
Colin,

How do you remove it.  On the left column there is an end date listed and I can't remove it. On the right column there is an end date and when I delete that it does save, but the other end date remains and I can't do any receiving on the subscription. I'll do a video for you if you need.

Nicole
Comment 3 Nicole C. Engard 2011-11-08 19:12:50 UTC
Created attachment 6257 [details]
left side - no way to remove the date and hit save
Comment 4 Nicole C. Engard 2011-11-08 19:13:18 UTC
Created attachment 6258 [details]
right side - i can delete

after saving the other date on the left remains and causes me to be unable to receive issues.
Comment 5 Colin Campbell 2011-11-09 12:32:21 UTC
If I click the date on the leftside date although it doesnt look editable and backspace through it, I can erase the date and save removes enddate.
Comment 6 Nicole C. Engard 2011-11-09 15:41:53 UTC
OOO, thanks for the tip!  We should make it more obvious :)

Nicole
Comment 7 Duncan 2011-12-19 00:48:39 UTC Comment hidden (obsolete)
Comment 8 Duncan 2011-12-19 00:51:26 UTC
Details on patch:

Gives a border to the dates on this page to make them obviously editable.

I suggest that this could be an issue which could be changed across the rest of Koha.
Comment 9 Katrin Fischer 2011-12-19 05:43:00 UTC
Created attachment 6857 [details] [review]
[SIGNED-OFF] Fix to make date obviously editable - bug 7193

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Patch changes all date fields on subscription entry to be
obvious input fields. This makes it more obvious that you
can enter dates manually and is more consistent with how
we handle dates in other places.
Comment 10 Ian Walls 2012-01-05 13:27:11 UTC
Simple template-only change to make the date editing look like it is (that is, possible!)

Passed QA
Comment 11 Paul Poulain 2012-01-06 14:51:25 UTC
patch pushed, please test

QA comment:
the patch also remove a few inline styling which should not be here (style="border-width: 0px;)