http://screencast.com/t/hthSz0Uz5 We discussed this on IRC - this is just the formal bug report. See also Bug 6679, which should have the patch applied that will fix this error.
This will be fixed by the application of these two patches: http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6270 http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6271 in that order.
Created attachment 6295 [details] [review] [Signed off] Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script. squashed chris_n's two patches. Label export works again. Don't change $_ in a list context Signed-off-by: Liz Rea <wizzyrea@gmail.com>
The line: @item_numbers = grep{my $number=$_; $number = {item_number => $number}} @item_numbers; follows the same pattern as the two lines above; should it not also be reverted? Can we confirm that labels with multiple item numbers work properly with this change still in place? What this original commit was trying to fix vs. what it actually did here seems divergent... the original bug report is about declaring variables in conditionals.
Created attachment 6307 [details] [review] Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script. squashed chris_n's two patches. Label export works again. Also changed the pattern for the item_number to the known working, critic friendly pattern. Don't change $_ in a list context Changed the 3rd bit to the critic friendly pattern chris_n suggests in the previous two lines.
This latest attachment will need a new signoff, as it's got an additional change in it.
Created attachment 6313 [details] [review] Bug 7207 - Reverting a portion of commit 607b5449bd5cb which breaks the label export script. squashed chris_n's two patches. Label export works again. Also changed the pattern for the item_number to the known working, critic friendly pattern. Don't change $_ in a list context Changed the 3rd bit to the critic friendly pattern chris_n suggests in the previous two lines. Signed-off-by: Brendan <brendan@bywatersolutions.com>
Updated bug has second signoff, and the fix pattern has been extended to all three lines, so I'm going to mark this one as Passed QA.
Patch pushed, BUT : * the screen cast did not work for me (I had a FF screen that was all black -and I don't speak about Rugby here ;-) ) * could not test the fix, I just can say the label-print.pl still compiles. SO : PLEASE DOUBLE TEST !
Updated a library partner of ours that was having a problem: they say it's now fixed in Firefox, but they're still having issues in IE. Since IE is never a good idea for the staff client, we're okay with the outcome. Consider this "one more data point"
Re-marking as trivial due to the problem with IE - would be nice to get a fix for that.
IE is not expected to work, so marking "RESO WONTFIX" for the IE problem. The other problem IS fixed