When you go to create new label layouts one of the fields is callnumber - what field is this pulling from? I've never seen it work, I always change it to itemcallnumber and then it works. I looked in the Koha to MARC mapping and don't see callnumber as a field that things are mapped to - so I'm a bit confused here. Nicole
Note that the sample data on a fresh install uses itemcallnumber in the layouts it creates, but when you choose a new layout it says callnumber by default in the list of fields.
Created attachment 6290 [details] callnumber instead of itemcallnumber
Created attachment 6292 [details] [review] Bug 7215 - changed callnumber PRESET field to itemcallnumber Fixes problem with creating new labels - before it populated with callnumber and not itemcallnumber
Created attachment 6293 [details] [review] [SIGNED-OFF] Bug 7215 - changed callnumber PRESET field to itemcallnumber Fixes problem with creating new labels - before it populated with callnumber and not itemcallnumber Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
QA: Did not test it, but looks good. Marked as Passed QA.
patch pushed, please test
This patch seems to have broken the unit tests for the label creator.
This is currently breaking the unit tests Testing Layout->new() method. # Failed test at t/db_dependent/Labels/t_Layout.t line 51. # Structures begin differing at: # $got->{format_string} = 'title, author, isbn, issn, itemtype, barcode, itemcallnumber' # $expected->{format_string} = 'title, author, isbn, issn, itemtype, barcode, callnumber' # New layout object FAILED to verify. # Testing Layout->get_attr() method. # Failed test at t/db_dependent/Labels/t_Layout.t line 55. # Layout->get_attr() FAILED on attribute format_string. Are the 2 failed tests. Looks like the tests weren't updated when the functionality was changed.
Created attachment 6737 [details] [review] Bug 7215 : The Module changed, but the tests weren't updated to reflect that Updating the test
follow-up patch pushed, we will see if jenkins is happy now. It should.
(In reply to comment #10) > follow-up patch pushed, we will see if jenkins is happy now. It should. I don't see this in master.
Included in the 3.6 branch prior to 3.6.4.