Bug 7215 - callnumber versus itemcallnumber
Summary: callnumber versus itemcallnumber
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Label/patron card printing (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Brendan Gallagher
QA Contact: Ian Walls
URL: /cgi-bin/koha/labels/label-edit-layou...
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-11 16:52 UTC by Nicole C. Engard
Modified: 2013-12-05 19:59 UTC (History)
6 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
callnumber instead of itemcallnumber (53.59 KB, image/png)
2011-11-11 17:08 UTC, Nicole C. Engard
Details
Bug 7215 - changed callnumber PRESET field to itemcallnumber (881 bytes, patch)
2011-11-11 17:27 UTC, Brendan Gallagher
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7215 - changed callnumber PRESET field to itemcallnumber (958 bytes, patch)
2011-11-11 17:29 UTC, Nicole C. Engard
Details | Diff | Splinter Review
Bug 7215 : The Module changed, but the tests weren't updated to reflect that (931 bytes, patch)
2011-12-13 08:20 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-11-11 16:52:21 UTC
When you go to create new label layouts one of the fields is callnumber - what field is this pulling from? I've never seen it work, I always change it to itemcallnumber and then it works.  

I looked in the Koha to MARC mapping and don't see callnumber as a field that things are mapped to - so I'm a bit confused here.

Nicole
Comment 1 Nicole C. Engard 2011-11-11 17:07:04 UTC
Note that the sample data on a fresh install uses itemcallnumber in the layouts it creates, but when you choose a new layout it says callnumber by default in the list of fields.
Comment 2 Nicole C. Engard 2011-11-11 17:08:55 UTC
Created attachment 6290 [details]
callnumber instead of itemcallnumber
Comment 3 Brendan Gallagher 2011-11-11 17:27:20 UTC Comment hidden (obsolete)
Comment 4 Nicole C. Engard 2011-11-11 17:29:39 UTC Comment hidden (obsolete)
Comment 5 Marcel de Rooy 2011-12-12 13:36:55 UTC
QA: Did not test it, but looks good. Marked as Passed QA.
Comment 6 Paul Poulain 2011-12-12 16:37:41 UTC
patch pushed, please test
Comment 7 Liz Rea 2011-12-12 17:47:42 UTC
This patch seems to have broken the unit tests for the label creator.
Comment 8 Chris Cormack 2011-12-12 17:58:12 UTC
This is currently breaking the unit tests


 Testing Layout->new() method.                                                                               
#   Failed test at t/db_dependent/Labels/t_Layout.t line 51.                                                  
#     Structures begin differing at:                                                                          
#          $got->{format_string} = 'title, author, isbn, issn, itemtype, barcode, itemcallnumber'             
#     $expected->{format_string} = 'title, author, isbn, issn, itemtype, barcode, callnumber'                 
# New layout object FAILED to verify.

# Testing Layout->get_attr() method.                                                                          
#   Failed test at t/db_dependent/Labels/t_Layout.t line 55.                                                  
# Layout->get_attr() FAILED on attribute format_string.

Are the 2 failed tests. Looks like the tests weren't updated when the functionality was changed.
Comment 9 Chris Cormack 2011-12-13 08:20:18 UTC
Created attachment 6737 [details] [review]
Bug 7215 : The Module changed, but the tests weren't updated to reflect that

Updating the test
Comment 10 Paul Poulain 2011-12-13 13:29:45 UTC
follow-up patch pushed, we will see if jenkins is happy now. It should.
Comment 11 Chris Nighswonger 2011-12-13 14:31:57 UTC
(In reply to comment #10)
> follow-up patch pushed, we will see if jenkins is happy now. It should.

I don't see this in master.
Comment 12 Jared Camins-Esakov 2012-05-23 12:26:39 UTC
Included in the 3.6 branch prior to 3.6.4.