Bug 7226 - Can't add tags on list
Summary: Can't add tags on list
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Lists (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) major (vote)
Assignee: Owen Leonard
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-15 15:47 UTC by Nicole C. Engard
Modified: 2013-12-05 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed fix (3.59 KB, patch)
2011-12-06 15:00 UTC, Owen Leonard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7226 - can't add tags on list (3.62 KB, patch)
2011-12-06 16:05 UTC, Nicole C. Engard
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7280 - can't place hold without selecting on list (1.38 KB, patch)
2011-12-06 16:09 UTC, Nicole C. Engard
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Nicole C. Engard 2011-11-15 15:47:55 UTC
when on a list and choosing to tag multiple items the tags are not added and there is no error.
Comment 1 Owen Leonard 2011-12-06 15:00:10 UTC Comment hidden (obsolete)
Comment 2 Nicole C. Engard 2011-12-06 16:05:36 UTC
Created attachment 6602 [details] [review]
[SIGNED-OFF] Bug 7226 - can't add tags on list

Incorrect check for TagsInputOnList was preventing the
right JavaScript from being triggered, and markup was
nested inside the wrong logic for the confirmation
message to be displayed consistently.

Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com>
Comment 3 Nicole C. Engard 2011-12-06 16:09:21 UTC Comment hidden (obsolete)
Comment 4 Nicole C. Engard 2011-12-06 16:09:50 UTC
Comment on attachment 6603 [details] [review]
[SIGNED-OFF] Bug 7280 - can't place hold without selecting on list

Attached wrong.
Comment 5 Paul Poulain 2011-12-16 17:16:56 UTC
QA comment: small patch, template change only
prove xt/author/valid-templates.t 
xt/author/valid-templates.t .. ok     
prove xt/author/translatable-templates.t
xt/author/translatable-templates.t .. ok   


passed QA

Patch pushed, please test