The koha-common Debian package should provide a sample koha-sites.conf file, so that people can see what the options are. Even better would be if it's possible to have an interactive mode in the package installer so that it requests the settings it needs (or maybe it could look up domain, etc., from somewhere else on the system?). This bug may be invalid. Please mark it as such if it is.
I'm wanting to make it ask debconf questions to populate the initial koha-sites.conf. it's been on my want-to-do list for a while, so definitely not invalid.
Created attachment 25707 [details] [review] Bug 7234: koha-common Debian package should include koha-sites.conf This patch adds a sample koha-sites.conf file, which will be included by the koha-common package in /etc/koha (where it belongs). It is fixed to include the current defaults (DOM indexing for bot biblios and authorities, disabled use of memcached, and good defaults for a normal setup if enabled). To test - verify that the defaults are sane (let me know if it needs to be fixed). - build the package and verify that the file gets installed. Regards To+ Sponsored-by: Universidad Nacional de Cordoba
I don't think the port should be 8080 for the staff client. We should be doing a name-based install by default, because tweaking the apache file after for production is beyond the scope of Koha. Also, Has Robin made any progress on the idea of a "debconf questions to populate the initial koha-sites.conf" concept?
Yeah, agreed on the port, it should be name-based (otherwise you have to enable it in ports.conf and such, but also name-based is more better.) Otherwise a good start, though perhaps we should have it with comments after the lines to show what this means and what the other options could be. It's good to have something until we get around to debconfing it properly. I should probably study the config for something like postfix, that will do the sort of thing that we need.
Created attachment 25718 [details] [review] Bug 7234: koha-common Debian package should include koha-sites.conf This patch adds a sample koha-sites.conf file, which will be included by the koha-common package in /etc/koha (where it belongs). It is fixed to include the current defaults (DOM indexing for both biblios and authorities, disabled use of memcached, and good defaults for a normal setup if enabled). All options are commented for ease of use by average users. To test - verify that the defaults are sane (let me know if it needs to be fixed). - build the package and verify that the file gets installed. Regards To+ Sponsored-by: Universidad Nacional de Cordoba
Created attachment 25721 [details] [review] [SIGNED OFF] Bug 7234: koha-common Debian package should include koha-sites.conf This patch adds a sample koha-sites.conf file, which will be included by the koha-common package in /etc/koha (where it belongs). It is fixed to include the current defaults (DOM indexing for both biblios and authorities, disabled use of memcached, and good defaults for a normal setup if enabled). All options are commented for ease of use by average users. To test - verify that the defaults are sane (let me know if it needs to be fixed). - build the package and verify that the file gets installed. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Created attachment 25750 [details] [review] Bug 7234: koha-common Debian package should include koha-sites.conf This patch adds a sample koha-sites.conf file, which will be included by the koha-common package in /etc/koha (where it belongs). It is fixed to include the current defaults (DOM indexing for both biblios and authorities, disabled use of memcached, and good defaults for a normal setup if enabled). All options are commented for ease of use by average users. To test - verify that the defaults are sane (let me know if it needs to be fixed). - build the package and verify that the file gets installed. Regards To+ Sponsored-by: Universidad Nacional de Cordoba Signed-off-by: Mark Tompsett <mtompset@hotmail.com> Signed-off-by: Robin Sheat <robin@catalyst.net.nz>
I like that, it's good :)
Pushed to master. Thanks, Tomás!
Pushed to 3.14.x, will be in 3.14.07