Created attachment 6337 [details] screenshot of errors in web installer While installing italian and UNIMARC version of Koha via web installer, two errors occur: ERROR 1136 (21S01) and ERROR 1064 (42000). Some tables can't be populated with mandatory data. Errors are related to files sample_itemtypes.sql and unimarc_framework.sql (/usr/share/koha/intranet/cgi-bin/installer/data/mysql/it-IT/ and subdirectories).
Created attachment 6338 [details] [review] correct sample_itemtypes.sql
Created attachment 6339 [details] [review] correct unimarc_framework.sql
Thanks. Can you submit those corrected files as patches? Do you know how to do that?
You're welcome! Correct sql files are now attached, please check/test. Errors were related to sample_itemtypes.sql and unimarc_framework.sql. sample_itemtypes.sql INSERTs took one more field than expected by itemtypes table. I deleted the fifth value (originally set to 0 for each query), so now the fields are 6 insted of 7 (that is wrong). As to unimarc_framework.sql, the first two INSERT were performed as expected. The errors in the comments' syntax started from row 18, preventing the tables from being populated. Fabio
Created attachment 6348 [details] [review] Proposed patch
Tested patch. It is all. I sign-off the patch
Created attachment 6349 [details] [review] sign-off of the patch This the sign-off of the patch. I have tested it and I don't find problems
QA comment: I hesitate to mark failed QA but... there is a big mistake in the sql files: they are using short SQL statements: +INSERT INTO `itemtypes` VALUES ('BK', 'Libro',5,0,'bridge/book.gif',''); and not +INSERT INTO `itemtypes` (field1, field2, field3, field4, field5,...) VALUES ('BK', 'Libro',5,0,'bridge/book.gif',''); it means that the next modification in itemtypes will result in this bug being reopened, because it will fail again. Could you please fix the SQL and add the field names ? marking failed QA,
(In reply to comment #8) > QA comment: I hesitate to mark failed QA but... there is a big mistake in the > sql files: they are using short SQL statements: > +INSERT INTO `itemtypes` VALUES ('BK', 'Libro',5,0,'bridge/book.gif',''); > and not > > +INSERT INTO `itemtypes` (field1, field2, field3, field4, field5,...) VALUES > ('BK', 'Libro',5,0,'bridge/book.gif',''); > > it means that the next modification in itemtypes will result in this bug being > reopened, because it will fail again. > > Could you please fix the SQL and add the field names ? > > marking failed QA, You're right. it-IT/necessari/sample_itemtypes.sql contains incorrect SQL statements. But those statements are not introduced but this patch. There are already there in HEAD. IMO this issue should be covered by a separated bugzilla entry, and the attached patch should be applied since it fixes a real and current issue.
Created attachment 6744 [details] [review] patch with fileds (as asked RM) The patch with fields in sql insert
QA comment: no comment now, small patch. I've tested, it works fine. Patch pushed, please test. PS : welcome Fabio, you're 165th !
Just for the record: (In reply to comment #9) > You're right. it-IT/necessari/sample_itemtypes.sql contains incorrect SQL > statements. But those statements are not introduced but this patch. There are > already there in HEAD. IMO this issue should be covered by a separated bugzilla > entry, and the attached patch should be applied since it fixes a real and > current issue. Frederic was right, and I would have pushed the incomplete patch today if the proper patch had not been submitted. I'll write something on the wiki about how we (QA team) / I (RM) accept a patch or no.
Was changed by accident, setting back to original status.
This patch was incorporated into the 3.6.x branch prior to 3.6.4.