7251 – Fields are separated by "t" when the delimiter preference is set to "tabulation" in overdue_notices.pl

Bug 7251 - Fields are separated by "t" when the delimiter preference is set to "tabulation" in overdue_notices.pl

Summary: Fields are separated by "t" when the delimiter preference is set to "tabulati...

Status:	CLOSED FIXED

Alias:	None

Product:	Koha
Classification:	Unclassified
Component:	Command-line Utilities (show other bugs)
Version:	3.6
Hardware:	All All

Importance:	PATCH-Sent (DO NOT USE) normal
Assignee:	Frédérick Capovilla
QA Contact:	Ian Walls

URL:
Keywords:

Depends on:
Blocks:

Reported:	2011-11-21 17:34 UTC by Frédérick Capovilla
Modified:	2020-11-20 14:35 UTC (History)
CC List:	2 users (show)

See Also:	27045
Change sponsored?:	Sponsored
Patch complexity:	---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:
Circulation function:

Attachments
Corrects a problem in overdue_notices.pl when delimiter is set to tabulation (984 bytes, patch) 2011-11-21 17:34 UTC, Frédérick Capovilla	Details \| Diff \| Splinter Review
Bug 7251 : Corrects a problem in overdue_notices.pl when delimiter is set to tabulation (1.02 KB, patch) 2011-12-01 19:47 UTC, Chris Cormack	Details \| Diff \| Splinter Review
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Frédérick Capovilla 2011-11-21 17:34:58 UTC Comment hidden (obsolete)

Created attachment 6370 [details] [review]
Corrects a problem in overdue_notices.pl when delimiter is set to tabulation

In overdue_notices.pl, the letter "t" is used as a separator when the "delimiter" preference is set to "tabulation".
This happens because the word "tabulation" is passed as a separator character to CSV_XS. The first letter of the word is then used as a separator.

Patch attached that uses "\t" in that case.

Comment 1 Frédérick Capovilla 2011-11-21 17:35:58 UTC

Patch sponsored by the CCSR ( http://www.ccsr.qc.ca )

Comment 2 Chris Cormack 2011-12-01 19:47:03 UTC

Created attachment 6494 [details] [review]
Bug 7251 : Corrects a problem in overdue_notices.pl when delimiter is set to tabulation

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>

Comment 3 Ian Walls 2011-12-01 20:19:09 UTC

\t is a much better choice of separator than just 't', and actually corresponds to what 'tabulation' intends.  marking as passed QA

Comment 4 Paul Poulain 2011-12-06 16:13:44 UTC

patch pushed, please test

Comment 5 Jared Camins-Esakov 2012-05-23 12:19:37 UTC

Included in 3.6 prior to 3.6.5.