Today during training we had the staff perform "fast cataloging" (They were given items to checkout that where not in Koha) After creating the item (clicking the "add item" button) some of the books were immediately checked out to the patron, while others never went past the "add item" screen. If a "duplicate record suspected" message appears it will not automatically check the item out to the borrower after clicking "add item" It stays on the "edit items" screen. I'm not sure that's the only time something is not checked out, but it is certainly one reason a book won't be checked out when fast cataloged.
Hi Nicole, in my tests the checkouts didn't happen when you change the barcode on the item form. All other tests so far went well. Could this be the reason?
Katrin, That could be another reason, but if a duplicate if found most certainly doesn't check out the item. Nicole
Created attachment 14459 [details] [review] Proposed patch See commit comment
Created attachment 14489 [details] [review] [SIGNED-OFF] Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected.
Patch tested with a sandbox, by koha.aixmarseille <koha.aixmarseille@gmail.com>
Created attachment 14495 [details] [review] Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com>
Created attachment 14536 [details] [review] Proposed patch (follow-up 1) Follow-up to manage toolbar during fast cataloguing. Librarian may brake workflow by using some of its menus. See commit comment.
The follow-up will need a signoff.
Created attachment 15087 [details] [review] [SIGNED-OFF] Bug 7253: followup : manage toolbar for fastcataloging Follow-up has been signed-off with a sandbox by koha.aixmarseille (comment 8) but attachement did not change.
Created attachment 15218 [details] [review] Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com>
Created attachment 15219 [details] [review] Bug 7253: followup : manage toolbar for fastcataloging During fast cataloging, hide some toolbar menus of biblio edition page : - Save and view record - Z3950 Search - Framework change Also display "(fast cataloging)" in biblio and item editon. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested: - adding a fast add with duplicate and without - adding a new record, checked toolbar showed up correctly - editing existing record, checked toolbar showed up correctly
Created attachment 15220 [details] [review] Bug 7253: fast cataloging not always checking out When using fast cataloguing to create a biblio and item on the fly, workflow looses datas when a duplicate is detected. This comes from the use of a mix of circborrowernumber and borrowernumber in forms. This patch corrects by using always circborrowernumber in fast cataloguing workflow. Also adds html and uri escape for barecode where necessery. Test plan : With duplicate : - Go to a borrower circulation page - Enter a non existing barcode - Enter a due date - Click on "Check Out" => a message says the barcode was not found - Click on "Fast cataloguing" => The biblio edition page appears with fast cataloguing framework - Fill mandatory fields by using an existing ISBN - Click on "Save" => a yes/no message says "Duplicate record suspected" (Choosing yes will brake fast caloguing workflow, in this case librarian should create an item and checkout again) - Click on "No" => The item edition page appears with barcode already filled - Fill mandatory datas - Click on "Add item" => Borrower circulation page appears again, check that item has been checked out with the specified due date You may test without duplicate Signed-off-by: Nicole C. Engard <nengard@bywatersolutions.com> Tested following the plan and by fast cataloging a non-duplicate. All works as expected. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Created attachment 15221 [details] [review] Bug 7253: followup : manage toolbar for fastcataloging During fast cataloging, hide some toolbar menus of biblio edition page : - Save and view record - Z3950 Search - Framework change Also display "(fast cataloging)" in biblio and item editon. Signed-off-by: koha.aixmarseille <koha.aixmarseille@gmail.com> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Passes all tests and QA script. Tested: - adding a fast add with duplicate and without - adding a new record, checked toolbar showed up correctly - editing existing record, checked toolbar showed up correctly
This patch has been pushed to master.
Pushed to 3.10.x and 3.8.x will be in 3.10.4 and 3.8.11