Current code for selecting pending orders does not select orders from baskets with a closedate > 180 days. The code in Acquisition.pm already includes a FIXME for that. IMHO this part of the where clause should just be removed; an order is pending until it is filled. If you do not want to fill it, delete it.
Created attachment 6376 [details] [review] Patch
SQL-only change that removes an unjustified restriction. Signing off and passing QA in one.
(In reply to comment #2) > SQL-only change that removes an unjustified restriction. Signing off and > passing QA in one. Within an hour! Great..
Comment: this patch also removes the OR clodedate IS NULL, that is not related to the 180 days limit. Baskets were not removed if they are not closed. It seems logic to consider that a basket is pending if there are still things to recieve, the SQL query do that, so I accept the patch Patch pushed, please test