Bug 7254 - Show pending orders from baskets with closedate > 180 days
Summary: Show pending orders from baskets with closedate > 180 days
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Acquisitions (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Marcel de Rooy
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-11-23 12:44 UTC by Marcel de Rooy
Modified: 2012-10-25 23:09 UTC (History)
1 user (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Patch (1.38 KB, patch)
2011-11-23 12:55 UTC, Marcel de Rooy
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Marcel de Rooy 2011-11-23 12:44:14 UTC
Current code for selecting pending orders does not select orders from baskets with a closedate > 180 days.
The code in Acquisition.pm already includes a FIXME for that.
IMHO this part of the where clause should just be removed; an order is pending until it is filled. If you do not want to fill it, delete it.
Comment 1 Marcel de Rooy 2011-11-23 12:55:55 UTC
Created attachment 6376 [details] [review]
Patch
Comment 2 Ian Walls 2011-11-23 13:57:16 UTC
SQL-only change that removes an unjustified restriction.  Signing off and passing QA in one.
Comment 3 Marcel de Rooy 2011-11-23 13:58:33 UTC
(In reply to comment #2)
> SQL-only change that removes an unjustified restriction.  Signing off and
> passing QA in one.

Within an hour! Great..
Comment 4 Paul Poulain 2011-11-24 14:46:29 UTC
Comment: this patch also removes the OR clodedate IS NULL, that is not related to the 180 days limit. Baskets were not removed if they are not closed. It seems logic to consider that a basket is pending if there are still things to recieve, the SQL query do that, so I accept the patch

Patch pushed, please test