When looking for overdues, the combobox "Patron flags" has no effect. Three values are available in the list: Address in question Restricted Lost card None of this works (empty result) as the code currently assumes that these filters work with the "flags" field in the database. Actually, the form value should be compared instead with the contents of the gonenoaddress, debarred and lost fields. "Address in question" should filter by: gonenoaddress TRUE "Restricted" should filter by: debarred date >= current date "Lost card" should filter by: lost TRUE
Created attachment 6407 [details] [review] patch
Adrian + elsif ( $borflagsfilter eq 'lost') { + $strsth .= " AND borrowers.debarred <> 0"; + } Shouldn't that be checking lost not debarred?
Created attachment 6519 [details] [review] patch #2 Corrected the "lost" case which was checking the "debarred" field.
The first patch does not apply for me. Tried with git bz apply and git am -i3u. Applying: Bug 7266: filter on "Patron flags" in overdue.pl error: patch failed: circ/overdue.pl:266 error: circ/overdue.pl: patch does not apply Patch failed at 0001 Bug 7266: filter on "Patron flags" in overdue.pl If you can rebase this against current master, can you please also squash the two patches together? Thanks.
Created attachment 6884 [details] [review] proposed patch New patch ready.
Created attachment 6886 [details] [review] Bug 7266: flags debarred, suspended, gonenoaddress in overdue This patch makes these flags functionnal. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA comment: small patch, perlcritic compliant, passed QA. Won't work for 3.6, as it relies on fine in days
There have been no further reports of problems so I am marking this bug resolved.