Bug 7287 - overdue notification is processed several times if some sites do not have rules
Summary: overdue notification is processed several times if some sites do not have rules
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Tools (show other bugs)
Version: 3.6
Hardware: All All
: PATCH-Sent (DO NOT USE) normal (vote)
Assignee: Sophie MEYNIEUX
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-02 09:00 UTC by Sophie MEYNIEUX
Modified: 2013-12-05 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
BZ7287 : Fix overdue notification if a branch given as parameter does not have rules (860 bytes, patch)
2011-12-02 09:13 UTC, Sophie MEYNIEUX
Details | Diff | Splinter Review
Bug 7287 : Fix overdue notification if a branch given as parameter does not have rules (916 bytes, patch)
2011-12-04 03:44 UTC, Chris Cormack
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Sophie MEYNIEUX 2011-12-02 09:00:42 UTC
If you give a library as parameter and it does not have rules, all overdues are processed, even if they don't belong to that library.

To test this : 
- not defautlt rules
- one site with rules
- one other site without rule
- overdue issues in both sites
- execute :
  misc/cronjobs/overdue_notices.pl -t -library <code_of_site_without_rules>

As a result, a message is generated for every overdue issues in message_queue, not only for the one belonging to the site given as parameter
Comment 1 Sophie MEYNIEUX 2011-12-02 09:13:21 UTC Comment hidden (obsolete)
Comment 2 Chris Cormack 2011-12-04 03:41:40 UTC
Ohh good catch Sophie
Comment 3 Chris Cormack 2011-12-04 03:44:48 UTC
Created attachment 6557 [details] [review]
Bug 7287 : Fix overdue notification if a branch given as parameter does not have rules

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Comment 4 Paul Poulain 2011-12-14 17:11:33 UTC
QA comment : small (1 line patch), no comment

patch pushed, please test
Comment 5 Jared Camins-Esakov 2012-05-23 12:02:05 UTC
Included in 3.6 prior to 3.6.5.