The itemnumber is not passed in AddReserve function because parameters are not used correctly in C4/ILSDI.Services.pm. We have: $branch, $borrowernumber, $biblionumber, $constraint, $bibitems, $priority, $notes, $title, $checkitem, $found Instead of: $branch,$borrowernumber,$biblionumber,$constraint,$bibitems,$priority,$resdate,$expdate,$notes,$title,$checkitem,$found Probably because function Addreserve has changed.
Created attachment 6521 [details] [review] Proposed patch
Hmmm, this now also passes in the biblionumber as biblioitemnumber ... which may not always be the same thing. Luckily because it is constraint 'a' it isn't used. But I wonder if we should remove it so it isn't confusing in future?
Created attachment 10005 [details] [review] Bug 7299 passe itemnumber in ILSDI holditem service
This new patch does 2 things: - Remove biblioitemnumber - Add full namespace for call to CanItemBeReserved function
Created attachment 10447 [details] [review] Bug 7299 pass itemnumber in ILSDI holditem service Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
QA comment: I think you could have removed the # $branch, $borrowernumber, $biblionumber, $constraint, $bibitems, $priority, $notes, $title, $checkitem, $found instead of fixing it, but that's not worth failing QA ;-) Small patch. Also add C4::Reserves:: probably needed because of nested packages.