Created attachment 6570 [details] Sample Search Please see attached: Search by Category Codes shows all patrons in all categories. Displays "()" as category for all patrons.
Created attachment 7269 [details] [review] Patch to fix display Category variables were not being sent to the template, this patch uses code from members.pl to define those variables and send them to the template. It does not fix the searching issue. The code seems to be written to search for category_type, instead of categorycode, even though the label on the search reads 'Category Code.' Should it be searching for code or type? The original category column in the results displayed the category code description followed by the category type. The searching should also be fixed in conjunction with bug 5502.
Created attachment 7670 [details] [review] Bug 7318 - filtering patron card creator by category code does nothing This patch should fix the search issue - do note you have to use the *code* and not the *description* To test: * replicate the bug: * do a patron search in the patron card creator, with the sample data installed, for category code PT - you should get results from all category codes. * Apply the patch * do a patron search in the patron card creator, with the sample data installed, for category code PT * you will get only results in patron category PT.
Created attachment 7672 [details] [review] [Signed Off] Bug 7318: Fixes category display in patroncards Patron Search results. Category description and type were not being sent to the template. This patch fixes that issue, which also fixes the display. The display was showing 'Category Description (category type)'. It now displays 'Category Description (category code) to be consistent with the search label. This patch also assigns an empty string to $member to get rid of some 'uninitialized' errors in the logs. Signed-off-by: Liz Rea <wizzyrea@gmail.com> Confirm this patch fixes the display issue. Passes prove xt
Hm, why not have a pulldown with categories to choose one from? Perhaps a possible enhancemant for a follow up patch?
That would be fab, of course. I was kind of, erm, focused on getting the actual function working. I can work on that today. :) <chants>Incremental improvement! Incremental improvement!</chants>
That's why I said "follow up patch"! :) <chants>Incremental improvement! Incremental improvement!</chants>
Created attachment 7751 [details] [review] Bug 7318 - filtering patron card creator by category code does nothing This patch should fix the search issue - do note you have to use the *code* and not the *description* To test: * replicate the bug: * do a patron search in the patron card creator, with the sample data installed, for category code PT - you should get results from all category codes. * Apply the patch * do a patron search in the patron card creator, with the sample data installed, for category code PT * you will get only results in patron category PT. Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Fixes the search
I see 2 signed off patches here... changing status :)
I must be silly but I can't reproduce the problem (I misundestand what means "search by categorycode" ?) I was trying to search /cgi-bin/koha/members/member.pl, clicking +, selecting a given categorycode, it works without the patch. where's my mistake ?
(In reply to comment #9) > I must be silly but I can't reproduce the problem (I misundestand what means > "search by categorycode" ?) > I was trying to search /cgi-bin/koha/members/member.pl, clicking +, selecting a > given categorycode, it works without the patch. > > where's my mistake ? ok, forget me, it's in the title of the bug: Filtering *Patron Card Creator* by Category Code Does Nothing
QA comment * it seems that attachment 7751 [details] [review] has been merged into 7672, when I try to apply it, I get : "No changes -- Patch already applied." * small patch, nothing specific to say, passes tests
I believe the second patch has not been pushed. Could someone please test this and confirm whether the problem still exists, and, if it does not, clarify what it is that fixed it? Until the question is resolved, I will not be pushing this to 3.6.x.
FWIW, I reported the bug and applied the second patch. After applying the patch, the Card Creator now works as designed. I will happily endorse this patch and hope it gets pushed to stable as soon as possible. Thanks.
Paul, Could you please push the patch still attached to this bug? It doesn't seem to be in master. It passed QA a while ago.
(In reply to comment #14) > Paul, > > Could you please push the patch still attached to this bug? It doesn't seem > to be in master. It passed QA a while ago. When I try to apply this patch, I get: Applying: Bug 7318 - filtering patron card creator by category code does nothing Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... No changes -- Patch already applied. Moving to starting point so it seems it has been applied !(In reply to comment #13) > FWIW, I reported the bug and applied the second patch. After applying the > patch, the Card Creator now works as designed. I will happily endorse this > patch and hope it gets pushed to stable as soon as possible. Thanks. lsuarez, which version are you running ? that's probably the explanation !
bumping question for anyone = this patch seems to have been applied. Could someone confirm ?
There have been no further reports of problems so I am marking this bug resolved.