All emails show as mailto: links on the patron summary page, except for the alternate address email.
Created attachment 6607 [details] [review] Bug 7324: Show alternate email as mailto: / hide labels when field is empty Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now
Created attachment 6608 [details] [review] Bug 7324: Show alternate email as mailto: / hide labels when field is empty Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now Signed-off-by: Liz Rea <wizzyrea@gmail.com> Verified tests 1-3, looks good to me. Signed-off-by: Liz Rea <wizzyrea@gmail.com>
QA comment: After applying the patch, the language tool bar start floating... investigating in the code I think there is a div closed by mistake: + [% IF ( altcontactcountry ) %]<li><span class="label">Country: </span>[% altcontactcountry %]</li>[% END %] + [% IF ( altcontactphone ) %]<li><span class="label">Phone: </span>[% altcontactphone %]</li></ol></div>[% END %] marking failed QA. back to signed-off when you've submitted a new patch, it's a tiny one
Created attachment 6825 [details] [review] Bug 7324: Show alternate email as mailto: / hide labels when field is empty UPDATE 2011-12-15 Fixed wrong div that broke the patron account display. Thank you Paul for catching this! Changes made to the patron detail tab: - alternate email shows as mailto: link - labels for following fields only show when field is filled - initials - date of birth - gender - country (alternate address) - email (alternate address) - state (alternative contact) - country (alternative contact) - phone (alternative contact) To test: 1) Add new patron with minimal data and check the labels don't show 2) Change patron to have data in changed fields and check labels show 3) Check all email addresses are shown as mailto: links now Signed-off-by: Liz Rea <wizzyrea@gmail.com> Verified tests 1-3, looks good to me.
QA comment: this time everything is OK prove xt/author/translatable-templates.t xt/author/translatable-templates.t .. ok prove xt/author/valid-templates.t xt/author/valid-templates.t .. ok passed QA Note: that would be cool to hide all empty fields, like the ones in alternate addess and alternative contact. But this is a 1st step. patch pushed, please test
I was thinking about it but was not sure everyone would like this change. Perhaps we can get some opinions? There is a patch waiting to be pushed that will make it possible to configure which fields are shown for patron entry. Changing the summary page to only show fields that are not empty would go well with this change. (bug 6190)
I think for core informations, it must be displayed even if it's empty (address, phone, email), but for other informations (alternate), it can be hidden. The patch about displaying values in forms or not is related to data entry only if i'm not mistaking. So those patches are related... by completing what the other do. Plus you may want to have alternate address entered when you need it, but, when it's not entered, you may want not to display entries.