Bug 7328 - Expanded options in advanced search
Summary: Expanded options in advanced search
Status: CLOSED FIXED
Alias: None
Product: Koha
Classification: Unclassified
Component: Searching (show other bugs)
Version: 3.6
Hardware: All All
: P3 normal (vote)
Assignee: Frédéric Demians
QA Contact: Ian Walls
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2011-12-07 08:08 UTC by Frédéric Demians
Modified: 2013-12-05 19:57 UTC (History)
2 users (show)

See Also:
Change sponsored?: ---
Patch complexity: ---
Documentation contact:
Documentation submission:
Text to go in the release notes:
Version(s) released in:


Attachments
Proposed patch (1.91 KB, patch)
2011-12-07 08:11 UTC, Frédéric Demians
Details | Diff | Splinter Review
[SIGNED-OFF] Bug 7328 Expanded options in advanced search (2.08 KB, patch)
2011-12-08 06:36 UTC, Katrin Fischer
Details | Diff | Splinter Review

Note You need to log in before you can comment on or make changes to this bug.
Description Frédéric Demians 2011-12-07 08:08:34 UTC
In OPAC and intra advanced search, more search options are displayed
depending on expandedSearchOption syspres and user choice. This doesn't
work anymore in HEAD.
Comment 1 Frédéric Demians 2011-12-07 08:11:20 UTC Comment hidden (obsolete)
Comment 2 Katrin Fischer 2011-12-08 06:36:28 UTC
Created attachment 6660 [details] [review]
[SIGNED-OFF] Bug 7328 Expanded options in advanced search

In OPAC and intra advanced search, more search options are displayed
depending on expandedSearchOption syspres and user choice. This doesn't
work anymore in HEAD.

This patch restore this functionnality.

To test:

  - enable/disable expandedSearchOption.
  - Load advanced search page. Limited seach options version is always
    displayed
  - Apply this patch and see how it works...

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
The problem only appeared in the staff client for me.
Tested both OPAC and staff with patch applied.
Comment 3 Paul Poulain 2011-12-15 16:22:16 UTC
QA comment :
I can't see any difference with and without the patch.
Frédéric, looking at your code, it seems it does something only if the syspref is not defined, which should not happend.
Marking failed QA until I have more information about how to reproduce the problem
Comment 4 Frédéric Demians 2011-12-15 16:44:15 UTC
> QA comment :

Thanks for going through this patch.

> I can't see any difference with and without the patch.
> Frédéric, looking at your code, it seems it does something only if the
> syspref is not defined, which should not happend.

I don't think so.

Expanded search option are passed with a CGI param, it is used (and
controlled), otherwise syspref is used.

> Marking failed QA until I have more information about how to reproduce
> the problem

1. On HEAD, in intra interface, enable expandedSearchOption syspref
2. Click Search link in the top links bar.
3. Next to Search button, you can see [More options] link. This is wrong.
   We should have [Fewer options] 
4. Commit the patch
5. Repeat 1-2
6. Next to Search button, you have [Fewer options] link. This is
   correct.
Comment 5 Katrin Fischer 2011-12-16 09:06:25 UTC
Hi Paul, for me the problem only occured in the staff interface, not int he OPAC. Perhaps this helps.
Comment 6 Paul Poulain 2011-12-30 11:07:41 UTC
QA comment:
thanks for the explanation Frédéric, it worked now. I suspect I made something wrong in my 1st tests, because I hadn't this behaviour.

perlcritic catalogue/search.pl 
catalogue/search.pl source OK


passed QA

patch pushed, please test