Some of the tests in t/db_dependent expect data in the test database that isn't available in the sample data. This bug will be the home to the fixes for that issue.
Created attachment 6649 [details] [review] Bug 7333 - modifying Members.t to use a branchcode that exists in the sample data To test: Create a fresh koha db with all of the sample data (if you have one that has the sample branches in it, that will work too) run the test: prove t/db_dependent/Members.t All subtests should complete.
t/db_dependent/Serials.t requires at least one subscription in your test database to clear correctly. Plan: make the test create a subscription and remove it as part of the tests.
t/db_dependent/VirtualShelves.t requires at least 10x biblio records to pass tests. Not sure how to go about this one - make the test add 10x bibs or create a new sample data category for "required data for unit testing."
Created attachment 6652 [details] Bug 7333 - interim test db that will allow all db_dependent tests to pass
Comment on attachment 6652 [details] Bug 7333 - interim test db that will allow all db_dependent tests to pass hm I'm not sure I did that right. Maybe I"ll need to do it manually instead of with git bz.
Created attachment 6653 [details] Testing Database In the interim, this db should be usable to pass all db_dependent tests.
Created attachment 6734 [details] [review] [SIGNED-OFF] Bug 7333 - modifying Members.t to use a branchcode that exists in the sample data To test: Create a fresh koha db with all of the sample data (if you have one that has the sample branches in it, that will work too) run the test: prove t/db_dependent/Members.t All subtests should complete. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> All tests complete successfully with my database created from sample data and with the database provided on the bug.
Created attachment 6815 [details] [review] Bug 7333 - Fixing up db_dependent/Search.t to use sample data Thanks to Chris N. for helping figure out that it was because there were no French stopwords in the DB that the test was failing. Patch changes the French string (with French stopwords) to an English string with English stopwords, as only English stopwords are installed in the default data. This patch will allow Search.t to run on the database attached to this bug.
patch [SIGNED-OFF] Bug 7333 - modifying Members.t to use a branchcode that exists in the sample data pushed QA comment : fixes the problem (i made a fresh install of sample database)
Created attachment 6848 [details] [review] Bug 7333 - Fixing up db_dependent/Search.t to use sample data Thanks to Chris N. for helping figure out that it was because there were no French stopwords in the DB that the test was failing. Patch changes the French string (with French stopwords) to an English string with English stopwords, as only English stopwords are installed in the default data. This patch will allow Search.t to run on the database attached to this bug. Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Stumbled across this one accidentally too this morning and was preparing to send this patch line: Les chaussettes de l'archiduchesse with an English one to make this test not only function in a French environment But yours will probably be received without hurting less feelings ;) Updating patch status..
patch pushed, please test
There have been no further reports of problems so I am marking this bug resolved.